Bug 7283 - Build fix for !defined(XF86DRI)
Summary: Build fix for !defined(XF86DRI)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) OpenBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-20 14:57 UTC by Matthieu Herrb
Modified: 2006-06-21 00:44 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch (1.33 KB, patch)
2006-06-20 14:59 UTC, Matthieu Herrb 		no flags Details | Splinter Review
View All

Description Matthieu Herrb 2006-06-20 14:57:18 UTC 
Once again, changes to the radeon driver where not tested without DRI support.
Comment 1 Matthieu Herrb 2006-06-20 14:59:34 UTC 
Created attachment 5998 [details] [review]
Proposed patch

I'm not sure if the using pScrn->depth instead of info->depthBits in
RADEONChangeSurfaces() is ok.
Comment 2 Michel Dänzer 2006-06-21 00:44:11 UTC 
(In reply to comment #0)
> Once again, changes to the radeon driver where not tested without DRI support.

It would be a lot of overhead for me to check this every time (I was actually
suspecting these changes to break and meaning to check it, but hadn't got around
to it, and might still have been fooled by the fact that --disable-dri doesn't
even cut it, as xorg-server.h defines XF86DRI). Your heads up are much
appreciated though.

(In reply to comment #1)
> 
> I'm not sure if the using pScrn->depth instead of info->depthBits in
> RADEONChangeSurfaces() is ok.

It's not, that's the whole point of info->depthBits. :)

Fixed in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.