Bug 72896 - [BYT] DP(Port B) can't light up after loading i915 driver.
Summary: [BYT] DP(Port B) can't light up after loading i915 driver.
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: high critical
Assignee: Todd Previte
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
: 69596 72897 73477 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-20 06:50 UTC by Guang Yang
Modified: 2016-10-12 09:01 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesgofDPwithtoddpatch.log (60.00 KB, text/plain)
2013-12-20 06:51 UTC, Guang Yang
no flags Details

Description Guang Yang 2013-12-20 06:50:28 UTC
System Environment:
--------------------------
Platform: BYT-M
kernel:   (drm-intel-nightly)f0404eaa3ab8607058a3581e0d691d35ca4b79bd

Bug detailed description:
---------------------------
DP(Port B) can light up at GRUB step, but black screen after loading I915 driver. With testdisplay -i, it shows DP connected. I have already tried Todd's hotplug patch, the issue still exsits.

This issue have already tracked at JIRA(https://jira01.devtools.intel.com/browse/VIZ-3326), now moved to FDO.

The testdisplay -i shows:
[root@x-byt01 tests]# ./testdisplay -i
Connectors:
id encoder status type size (mm) modes
20 19 connected eDP 280x160 1
modes:
name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot flags type clock
[0] 1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
9 0 disconnected VGA 0x0 0
12 0 disconnected HDMI-A 0x0 0
16 15 connected DP 480x270 35
modes:
name refresh (Hz) hdisp hss hse htot vdisp vss vse vtot flags type clock
[0] 1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 148500
[1] 1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 148352
[2] 1920x1080 60 1920 1968 2000 2080 1080 1083 1088 1110 0x9 0x40 138500
[3] 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74250
[4] 1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74176
[5] 1920x1080 50 1920 2448 2492 2640 1080 1084 1089 1125 0x5 0x40 148500
[6] 1920x1080i 50 1920 2448 2492 2640 1080 1084 1094 1125 0x15 0x40 74250
[7] 1600x1200 60 1600 1664 1856 2160 1200 1201 1204 1250 0x5 0x40 162000
[8] 1680x1050 60 1680 1784 1960 2240 1050 1053 1059 1089 0x6 0x40 146250
[9] 1280x1024 75 1280 1296 1440 1688 1024 1025 1028 1066 0x5 0x40 135000
[10] 1280x1024 60 1280 1328 1440 1688 1024 1025 1028 1066 0x5 0x40 108000
[11] 1440x900 60 1440 1520 1672 1904 900 903 909 934 0x6 0x40 106500
[12] 1280x960 60 1280 1376 1488 1800 960 961 964 1000 0x5 0x40 108000
[13] 1366x768 60 1366 1436 1579 1792 768 771 774 798 0x5 0x40 85500
[14] 1152x864 75 1152 1216 1344 1600 864 865 868 900 0x5 0x40 108000
[15] 1280x720 60 1280 1390 1430 1650 720 725 730 750 0x5 0x40 74250
[16] 1280x720 60 1280 1390 1430 1650 720 725 730 750 0x5 0x40 74176
[17] 1280x720 50 1280 1720 1760 1980 720 725 730 750 0x5 0x40 74250
[18] 1024x768 75 1024 1040 1136 1312 768 769 772 800 0x5 0x40 78800
[19] 1024x768 70 1024 1048 1184 1328 768 771 777 806 0xa 0x40 75000
[20] 1024x768 60 1024 1048 1184 1344 768 771 777 806 0xa 0x40 65000
[21] 832x624 75 832 864 928 1152 624 625 628 667 0xa 0x40 57284
[22] 800x600 75 800 816 896 1056 600 601 604 625 0x5 0x40 49500
[23] 800x600 72 800 856 976 1040 600 637 643 666 0x5 0x40 50000
[24] 800x600 60 800 840 968 1056 600 601 605 628 0x5 0x40 40000
[25] 800x600 56 800 824 896 1024 600 601 603 625 0x5 0x40 36000
[26] 720x576 50 720 732 796 864 576 581 586 625 0xa 0x40 27000
[27] 720x480 60 720 736 798 858 480 489 495 525 0xa 0x40 27027
[28] 720x480 60 720 736 798 858 480 489 495 525 0xa 0x40 27000
[29] 640x480 75 640 656 720 840 480 481 484 500 0xa 0x40 31500
[30] 640x480 73 640 664 704 832 480 489 491 520 0xa 0x40 31500
[31] 640x480 67 640 704 768 864 480 483 486 525 0xa 0x40 30240
[32] 640x480 60 640 656 752 800 480 490 492 525 0xa 0x40 25200
[33] 640x480 60 640 656 752 800 480 490 492 525 0xa 0x40 25175
[34] 720x400 70 720 738 846 900 400 412 414 449 0x6 0x40 28320
18 0 disconnected HDMI-A 0x0 0
CRTCs:
id fb pos size
3 54 (0,0) (1920x1080)
1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
6 54 (0,0) (1920x1080)
1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x40 148500
Comment 1 Guang Yang 2013-12-20 06:51:30 UTC
Created attachment 91018 [details]
dmesgofDPwithtoddpatch.log
Comment 2 Daniel Vetter 2014-01-09 08:17:33 UTC
[    8.484441] WARNING: CPU: 1 PID: 1198 at drivers/gpu/drm/i915/intel_display.c:1526 vlv_wait_port_ready+0x108/0x111 [i915]()

doesn't sound too good. Same holds for sister bug #72897, where on top of that we also have issues with the gtfifo. Do we fail to clean up BIOS state?
Comment 3 Todd Previte 2014-01-09 16:29:38 UTC
wait_port_ready() is waiting for the PLL to lock. Status for the PLL is in the line following that one - 
[67614.240023] timed out waiting for port B ready: 0xf000a0ff

The hotplug patch only resolves the issue of correcting the problem where DP hotplug is not visible on ports B or D because the bits are reversed (29 vs 27) in the definitions. So I would not expect that to have any effect on this issue or 72897.

As for not cleaning up BIOS state, that's a likely candidate and the code I've been working should resolve that. The new code follows the programming guide to the letter which is alleged to be a solution for this issue.
Comment 4 Todd Previte 2014-01-09 19:34:04 UTC
Correction - the PLL is locked but the PHYs for lanes aren't ready. 

-T
Comment 5 Todd Previte 2014-01-24 21:48:02 UTC
*** Bug 72897 has been marked as a duplicate of this bug. ***
Comment 6 Gordon Jin 2014-01-28 01:17:49 UTC
*** Bug 73477 has been marked as a duplicate of this bug. ***
Comment 7 Todd Previte 2014-02-03 23:27:44 UTC
This has been fixed and integrated into drm-intel-nightly. The relevant commits for fixing this problem are as follows:

drm/i915: fix initial timestamps for PP sequencing logic
http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-nightly&id=dada1a9ffccc832b0130658d26454d37bf41f610

drm/i915: fix wait_remaining_ms_from_jiffies
http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-nightly&id=ec5e0cfb19e79ce3a87b281ce4c2682eb659fa6e

drm/i915: vlv: fix DP PHY lockup due to invalid PP sequencer setup
http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-nightly&id=2cac613be8d4d661edd359cdab3c474286c4f5f0

drm/i915: VLV2 - Fix hotplug detect bits
http://cgit.freedesktop.org/~danvet/drm-intel/commit/?h=drm-intel-nightly&id=232a6ee9af8adb185640f67fcaaa9014a9aa0573
Comment 8 Guang Yang 2014-02-10 07:29:01 UTC
Verified, DP(port B) can work well.
Comment 9 Todd Previte 2014-02-12 15:37:53 UTC
*** Bug 69596 has been marked as a duplicate of this bug. ***
Comment 10 Jari Tahvanainen 2016-10-12 09:01:29 UTC
Closing verified+fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.