Bug 73057 - Module path in CMakeFileLists
Summary: Module path in CMakeFileLists
Status: RESOLVED WONTFIX
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-27 05:51 UTC by Gopalakrishna Palem
Modified: 2013-12-27 13:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Gopalakrishna Palem 2013-12-27 05:51:24 UTC
The module path setting in the CMakeLists.txt should be set to include existing module path. Right now, its overwriting the default definitions, which is causing problem when including poppler in other build systems.

The correct one should be as below:

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR}/cmake/modules)

Replace Line 5 of CMakeLists.txt file in the poppler root directory with the above line (note the additional ${CMAKE_MODULE_PATH} - it preserves the existing module path without overwriting it.)

Thank you,
GK 
http://gopalakrishna.palem.in
Comment 1 Albert Astals Cid 2013-12-27 11:53:05 UTC
why would you include poppler in a different build system?
Comment 2 Gopalakrishna Palem 2013-12-27 12:10:30 UTC
(In reply to comment #1)
> why would you include poppler in a different build system?

I see what you mean - but there are some cases where its easier to embed poppler as sub-directory and issue cmake from the top level font-end app - specially on Windows based machines, where poppler dependency binaries are not easy to get (so all are built from source).

Also, in general, its usually a practice to "append"/"prepend" module paths than overwrite them.
Comment 3 Albert Astals Cid 2013-12-27 12:15:00 UTC
If you're using poppler the way it is not intended, you have to deal with the problems it may bring you.
Comment 4 Gopalakrishna Palem 2013-12-27 12:41:11 UTC
(In reply to comment #3)
> If you're using poppler the way it is not intended, you have to deal with
> the problems it may bring you.

Hmm...thats a bit rude...

Overwriting module paths or any other system variables is NOT the intended way of using CMAKE either !! 

Anyway, I have no intention of correcting the poppler mistakes here, if they are "intended" by design.

Please feel free to close this bug as "by design".

Thank you,
GK 
http://gopalakrishna.palem.in/
Comment 5 Gopalakrishna Palem 2013-12-27 12:52:32 UTC
Please ensure that it is "intended" and "by design" before marking it as "resolved".


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.