Bug 73326 - xdm uses arc4random and setproctitle without proper includes
Summary: xdm uses arc4random and setproctitle without proper includes
Status: RESOLVED MOVED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xdm (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 85246 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-06 15:51 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2018-08-10 20:29 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
build.log from Gentoo (119.54 KB, text/plain)
2014-01-06 15:51 UTC, Chí-Thanh Christopher Nguyễn
no flags Details
xdm-1.1.11-arc4random-include.patch (360 bytes, patch)
2014-01-06 15:52 UTC, Chí-Thanh Christopher Nguyễn
no flags Details | Splinter Review
xdm-1.1.11-setproctitle-include.patch (849 bytes, patch)
2014-01-06 15:52 UTC, Chí-Thanh Christopher Nguyễn
no flags Details | Splinter Review

Description Chí-Thanh Christopher Nguyễn 2014-01-06 15:51:40 UTC
Created attachment 91543 [details]
build.log from Gentoo

According to arc4random(3), on BSD or OS X
#include <stdlib.h>
while on Linux systems with libbsd,
#include <bsd/stdlib.h>
is needed.

A similar issue exists with setproctitle(3). This will cause the compiler to complain about implicit function declarations.
Comment 1 Chí-Thanh Christopher Nguyễn 2014-01-06 15:52:29 UTC
Created attachment 91544 [details] [review]
xdm-1.1.11-arc4random-include.patch
Comment 2 Chí-Thanh Christopher Nguyễn 2014-01-06 15:52:47 UTC
Created attachment 91545 [details] [review]
xdm-1.1.11-setproctitle-include.patch
Comment 3 Laurent Bigonville 2015-12-11 20:15:49 UTC
*** Bug 85246 has been marked as a duplicate of this bug. ***
Comment 4 Laurent Bigonville 2015-12-11 20:23:48 UTC
Hi,

Any progress on this bug? I'm also experiencing this issue
Comment 5 Alan Coopersmith 2015-12-11 20:44:33 UTC
Sorry, we rarely collect patches from bugzilla - mostly we review patches
submitted to the xorg-devel mailing list:
http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches/

(This is annoying, but we don't even have enough people working on this to
 keep up with patches that arrive in our inbox, much less those stuck in
 bugzilla where it's easy to forget.)
Comment 6 GitLab Migration User 2018-08-10 20:29:38 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/app/xdm/issues/4.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.