Bug 73409 - include telepathy-farstream 1.0 in telepathy-glib
Summary: include telepathy-farstream 1.0 in telepathy-glib
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-farstream (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 73551
  Show dependency treegraph
 
Reported: 2014-01-08 20:36 UTC by Simon McVittie
Modified: 2014-01-13 13:14 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[tp-glib, before merge] COPYING: delete unused BSD licenses (4.08 KB, patch)
2014-01-08 20:37 UTC, Simon McVittie
Details | Splinter Review
[tpfs 1/8] Update tools from telepathy-glib (66.08 KB, patch)
2014-01-08 20:37 UTC, Simon McVittie
Details | Splinter Review
[tpfs 2/8] Catch up with GLib deprecations (3.61 KB, patch)
2014-01-08 20:38 UTC, Simon McVittie
Details | Splinter Review
[tpfs 3/8] Link g-i bindings to the correct telepathy-glib version (855 bytes, patch)
2014-01-08 20:38 UTC, Simon McVittie
Details | Splinter Review
[tpfs 4/8] TfCallStream: include missing header (747 bytes, patch)
2014-01-08 20:39 UTC, Simon McVittie
Details | Splinter Review
[tpfs 5/8] TfCallContent: compile with -Werror=shadow (2.35 KB, patch)
2014-01-08 20:39 UTC, Simon McVittie
Details | Splinter Review
[tpfs 8/8] Remove unused Autoconf macros (5.38 KB, patch)
2014-01-08 20:40 UTC, Simon McVittie
Details | Splinter Review
[tp-glib, after merge] Flatten telepathy-farstream/README into the top-level README (5.90 KB, patch)
2014-01-08 20:41 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2014-01-08 20:36:14 UTC
Similar to Bug #71100 (and Telepathy-Qt for that matter), I think telepathy-farstream should be part of telepathy-glib source releases.
Comment 1 Simon McVittie 2014-01-08 20:37:29 UTC
Created attachment 91698 [details] [review]
[tp-glib, before merge] COPYING: delete unused BSD licenses

We had a prefix and suffix for non-LGPL licenses, but we no longer
ship the BSD-licensed code, so we don't need those any more. (Also,
this project is telepathy-glib, not Gabble.)
Comment 2 Simon McVittie 2014-01-08 20:37:55 UTC
Created attachment 91699 [details] [review]
[tpfs 1/8] Update tools from telepathy-glib
Comment 3 Simon McVittie 2014-01-08 20:38:19 UTC
Created attachment 91700 [details] [review]
[tpfs 2/8] Catch up with GLib deprecations
Comment 4 Simon McVittie 2014-01-08 20:38:39 UTC
Created attachment 91701 [details] [review]
[tpfs 3/8] Link g-i bindings to the correct telepathy-glib version
Comment 5 Simon McVittie 2014-01-08 20:39:21 UTC
Created attachment 91702 [details] [review]
[tpfs 4/8] TfCallStream: include missing header

This fixes compilation with -Werror=missing-prototypes.
Comment 6 Simon McVittie 2014-01-08 20:39:49 UTC
Created attachment 91703 [details] [review]
[tpfs 5/8] TfCallContent: compile with -Werror=shadow

tp_asv_get_boolean() is documented to return FALSE in the "not valid"
case, so there's no need to check it separately here. This avoids
shadowing a variable named valid at function scope.
    
j was previously named i, shadowing another i at function scope.
Comment 7 Simon McVittie 2014-01-08 20:40:21 UTC
Created attachment 91704 [details] [review]
[tpfs 8/8] Remove unused Autoconf macros

We still use AS_COMPILER_FLAG for now.
Comment 9 Simon McVittie 2014-01-08 20:41:59 UTC
Created attachment 91705 [details] [review]
[tp-glib, after merge] Flatten telepathy-farstream/README into the top-level README

Also drop parts of telepathy-logger/README that are redundant with the
top-level README.
Comment 10 Olivier Crête 2014-01-08 20:52:45 UTC
All the patches look good to me, merge 'em all !
I assume you ran the python example and they still work?
Comment 11 Simon McVittie 2014-01-09 12:18:11 UTC
(In reply to comment #10)
> I assume you ran the python example and they still work?

Not yet - I don't have a full-stack Telepathy 1.0 setup yet, apart from individual modules' "make check", since MC and the Logger still share some directory names between 0.x and 1.0.

Which examples should I expect to work? examples/python/ don't look as though they're going to work (telepathy-python, Gst 0.10 and static bindings - Bug #69435). I don't intend to upgrade telepathy-python to Telepathy 1.0 since it's already obsolete.

If I can expect call-handler.c to work, I can test that on a spare machine at some point, using examples/client/python/dialler.py from telepathy-glib...
Comment 12 Olivier Crête 2014-01-09 16:08:27 UTC
I was thinking of call-handler. If the python examples no longer work and you don't intend to port them, then feel free to delete them.
Comment 13 Simon McVittie 2014-01-13 11:55:55 UTC
Since my available time for Tp 1.0 is erratic, and it isn't a stable or necessarily even functional branch yet, I'm going to merge this untested, and worry about testing later: it's not as if this is a functionality regression. I'll clone a bug for "make sure it actually works"...
Comment 14 Simon McVittie 2014-01-13 13:14:04 UTC
Included in telepathy-glib 0.99.6


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.