Bug 73424 - mpeg2 video shows green artifacts
Summary: mpeg2 video shows green artifacts
Status: RESOLVED FIXED
Alias: None
Product: libva
Classification: Unclassified
Component: intel (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: haihao
QA Contact: Sean V Kelley
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 08:24 UTC by Rainer Hochecker
Modified: 2014-05-26 05:13 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
A scatch patch, just for testing, could you give a try ? (490 bytes, patch)
2014-05-05 02:56 UTC, haihao
Details | Splinter Review
build the right reference list (487 bytes, patch)
2014-05-08 03:16 UTC, haihao
Details | Splinter Review

Description Rainer Hochecker 2014-01-09 08:24:36 UTC
This behavior can be reproduced with e.g. XBMC 12 or 13. I did this test on Ubuntu Saucy.
The provided sample works fine on Windows DXVA and Linux vdpau (Nvidia).
Comment 1 Rainer Hochecker 2014-01-09 08:26:05 UTC
sample can be downloaded here:  https://www.dropbox.com/s/h9pw3sv5pvytugy/12%20Angry%20Men%20%281957%29%20%281%29-001.mkv
Comment 2 Bernd Kuhls 2014-01-23 19:26:49 UTC
Duplicate of #72522?
Comment 3 Rainer Hochecker 2014-01-23 19:32:41 UTC
I don't think so. #72522 talks about deinterlaceing, the sample provided here is progressive.
Comment 4 James Berry 2014-01-23 19:40:41 UTC
Sample is progressive and sourced from professionally encoded DVD (not transcoded). I have another half dozen examples (at least) which exhibit the same problem, all progressive. I can supply more if required.
Comment 5 James Berry 2014-01-23 19:47:52 UTC
Picture (photo) of file playing in XBMC - block artefacts are very different from #72552 http://imgur.com/ZelKUlf
Comment 6 kn88 2014-02-13 12:55:40 UTC
I'd like to note, I've noticed that mediainfo for video files with this problem shows "Standard: Component"

Files that are OK show "Standard: NTSC"
Comment 7 James Berry 2014-02-13 17:01:57 UTC
I don't believe that this is the common cause, or at least not the only trigger.

A quick flick through my collection of films shows these that are affected.  Note that the source of these MPEG2 files is from DVD without transcoding, so these are as authored.  S

12 Angry Men  http://paste.ubuntu.com/5888803/ 
Lego Star Wars Empire Strikes Out:  http://paste.ubuntu.com/5894916/
Fantastic Mr Fox  http://paste.ubuntu.com/5974123/ 
African Queen (interlaced)  http://paste.ubuntu.com/5986502/ 
Austin Powers (man of mystery):  http://paste.ubuntu.com/5986552/ 
Babe:  http://paste.ubuntu.com/5986557/

African Queen is PAL
Austin Powers is NTSC
Comment 8 kn88 2014-02-22 22:54:22 UTC

(In reply to comment #7)
> I don't believe that this is the common cause, or at least not the only
> trigger.
> 
> A quick flick through my collection of films shows these that are affected. 
> Note that the source of these MPEG2 files is from DVD without transcoding,
> so these are as authored.  S

Mine are all also from DVD without transcoding, so they have that in common.
Comment 9 James Berry 2014-04-29 10:05:53 UTC
@haihao have you repro'd this problem? Do you need any further files?
Comment 10 haihao 2014-05-05 02:56:56 UTC
Created attachment 98441 [details] [review]
A scatch patch, just for testing, could you give a try ?
Comment 11 Peter Frühberger 2014-05-05 11:56:07 UTC
Hi Haihao,

thx for that patch. We tested it ontop of latest stable (1.3.x) libva-driver-intel, but sadly it did not change anything. Though not fully understanding what the patch does - is it some workaround to empty the batch?
Comment 12 haihao 2014-05-06 05:02:31 UTC
The patch is to make sure the operation is done before the next batch buffer.  I can reproduce this issue on HSW with the sample mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=72522.  It works OK for me if applying the patch.
Comment 13 Rainer Hochecker 2014-05-06 05:31:31 UTC
I have tried this patch on a i5 hsw system and it does not change anything playing the provided sample. artifacts are still there.
Comment 14 Rainer Hochecker 2014-05-06 05:33:53 UTC
@haihao the sample not working is this one, not the one from the other bug

https://www.dropbox.com/s/h9pw3sv5pvytugy/12%20Angry%20Men%20%281957%29%20%281%29-001.mkv
Comment 15 haihao 2014-05-08 03:08:47 UTC
Oh, the issue I encountered is different from yours.  Sorry for confusing you.
Comment 16 haihao 2014-05-08 03:14:50 UTC
The samples are not conformed to the 13818-2 spec:

"frame_pred_frame_dct shall be ‘1’ if progressive_frame is ‘1’."
Comment 17 haihao 2014-05-08 03:16:28 UTC
Created attachment 98658 [details] [review]
build the right reference list

Could you give a try with this patch ?
Comment 18 Rainer Hochecker 2014-05-08 05:34:23 UTC
this patch fixes the issue here. thanks!
Comment 19 James Berry 2014-05-08 08:55:51 UTC
I will try and get a build working so I can test against my other video files that exhibit this problem. I will report back soon!
Comment 20 James Berry 2014-05-08 20:56:15 UTC
I have about half a dozen files which exhibited this problem, they are now resolved with this patch
Comment 21 haihao 2014-05-26 05:13:38 UTC
commit 3afe0514162332e923092000940ee8e99979a817
Author: Xiang, Haihao <haihao.xiang@intel.com>
Date:   Fri May 9 16:31:54 2014 +0800

    mpeg2: check frame_pred_frame_dct instead of progressive_frame


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.