Bug 73688 - [Regression HSW ULT] Calltrace when system resume from S4: WARNING: CPU: 0 PID: 6 at drivers/gpu/drm/i915/intel_display.c:10299 intel_get_pipe_from_connector+0x26/0x3c [i915]()
Summary: [Regression HSW ULT] Calltrace when system resume from S4: WARNING: CPU: 0 PI...
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Jesse Barnes
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 08:40 UTC by Qingshuai Tian
Modified: 2017-10-06 14:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
dmesg after system resume from s4 (121.79 KB, text/plain)
2014-01-16 08:40 UTC, Qingshuai Tian 		no flags Details
View All

Description Qingshuai Tian 2014-01-16 08:40:07 UTC 
Created attachment 92209 [details]
dmesg after system resume from s4

Environment:
-------------------
  Kernel: (drm-intel-next-queued) f1fcde49872f390a4060fa9ee8b02d3f2a8508b7
  Machin Info: Lenovo idealpad u330p

Description:
--------------------
When testing s4 on a HSW ULT, there is Call trace information in dmesg after the machine resume. You can check the dmesg in the attachment. 
The Call trace will disappear when test with parameter "i915.modeset=0".
It's a regression, and I biscted it.

Bisect shows:
--------------------
752aa88a1e784c22d514db3b440e49427b58259e is the first bad commit
commit 752aa88a1e784c22d514db3b440e49427b58259e
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Oct 31 18:55:49 2013 +0200

    drm/i915: make backlight functions take a connector

    On VLV/BYT, backlight controls a per-pipe, so when adjusting the
    backlight we need to pass the correct info.  So make the externally
    visible backlight functions take a connector argument, which can be used
    internally to figure out the pipe backlight to adjust.

    v2: make connector pipe lookup check for NULL crtc (Jani)
        fixup connector check in ASLE code (Jani)
    v3: make sure we take the mode config lock around lookups (Daniel)
    v4: fix double unlock in panel_get_brightness (Daniel)
    v5: push ASLE work into a work queue (Daniel)
    v6: separate ASLE work to a prep patch, rebase (Jani)

    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

:040000 040000 8c3767165764c6e36b90d9e62b1e23940071d909 2d0aa55819f045debb6e14208bc30e6de516255f M   drivers


Test Step:
--------------------
1.boot up machine
2.echo disk > /sys/power/state
Comment 1 Jesse Barnes 2014-01-16 20:16:23 UTC 
Should be fixed already, do you have an old tree?

commit 7c063c725987406d743cc7de7625ff224fab75de
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Tue Nov 26 09:13:41 2013 -0800

    drm/i915: take mode config lock around crtc disable at suspend
Comment 2 Qingshuai Tian 2014-01-20 03:31:10 UTC 
I retested with the latest kernel from drm-intel-next-queued branch on Daniel's tree.  The bug did have be fixed. :)

The kernel I used in comment 1 was also from Daniel's tree, but the commit wasn't latest and may be rebased already. Sorry for that.
Comment 3 Elizabeth 2017-10-06 14:40:19 UTC 
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.