Bug 73881 - [next] account-storage/default-keyring-storage.py failing
Summary: [next] account-storage/default-keyring-storage.py failing
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 15:42 UTC by Guillaume Desmottes
Modified: 2019-12-03 20:13 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
full log (234.12 KB, text/plain)
2014-01-21 15:43 UTC, Guillaume Desmottes
Details
disable tests relying on the old account location (2.11 KB, patch)
2014-01-22 13:00 UTC, Guillaume Desmottes
Details | Splinter Review

Description Guillaume Desmottes 2014-01-21 15:42:28 UTC
next 7e7e938e0a638b99bba3dc4d5f01f6e7534231c1

Traceback (most recent call last):
  File "/home/cassidy/dev/telepathy-mission-control/tests/twisted/mctest.py", line 151, in exec_test_deferred
    fun(queue, bus, mc, **kwargs)
  File "/home/cassidy/dev/telepathy-mission-control/tests/twisted/account-storage/default-keyring-storage.py", line 304, in test
    assert not os.path.exists(old_key_file_name)
AssertionError
Comment 1 Guillaume Desmottes 2014-01-21 15:43:30 UTC
Created attachment 92522 [details]
full log
Comment 2 Guillaume Desmottes 2014-01-21 15:52:35 UTC
Looks like it has been broken with this patch:

commit 7e7e938e0a638b99bba3dc4d5f01f6e7534231c1
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Oct 31 17:19:40 2013 +0100

    comment out code using the old file location


Should we disable this test while we finished implementing the new accounts location for 1.0?
Comment 3 Simon McVittie 2014-01-22 11:52:08 UTC
Skipping it (raise SystemExit(77)) is probably the right thing for now, and we can reinstate it when I add 0.x account import, or chop it up for Bug #27727.
Comment 4 Guillaume Desmottes 2014-01-22 13:00:32 UTC
Created attachment 92580 [details] [review]
disable tests relying on the old account location
Comment 5 Simon McVittie 2014-01-22 13:04:14 UTC
Comment on attachment 92580 [details] [review]
disable tests relying on the old account location

Review of attachment 92580 [details] [review]:
-----------------------------------------------------------------

Go for it, but that's more tests than I'd really hoped, so please leave the bug open and I'll try to get to this soon.
Comment 6 Guillaume Desmottes 2014-01-22 13:37:01 UTC
Merged.
Comment 7 GitLab Migration User 2019-12-03 20:13:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-mission-control/issues/78.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.