Bug 73957 - [ILK Bisected]Piglit/spec_glsl-1.10_execution_vs-call-in-nested-loop fails
Summary: [ILK Bisected]Piglit/spec_glsl-1.10_execution_vs-call-in-nested-loop fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: lu hua
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 06:23 UTC by lu hua
Modified: 2014-01-26 01:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2014-01-23 06:23:54 UTC
System Environment:
--------------------------
Platform: Ironlake 
Libdrm:		(master)libdrm-2.4.52
Mesa:		(master)1032c33cb93f1e8839be0f743b81492c2ca87e39
Xserver:	(master)xorg-server-1.15.0-1-ga92c6406e7f6c0b74fb1cb9361ad904facc0f722
Xf86_video_intel:(master)2.99.907-46-g2c441079cbd52902d356b652659e2be84726940e
Cairo:		(master)2a7f133639bed86a29dd9693cb78c0aa42eaff30
Libva:		(staging)79ddde6bab54618046f136471c020c08ff4fde50
Libva_intel_driver:(staging)6736a39fce442a8e5abb2a2e99adf56e3965d35f
Kernel:	(drm-intel-nightly) 164a4cb4c1431a0689f85507868356fae24da638

Bug detailed description:
-----------------------------
It fails on Ironlake with mesa master branch. It doesn't happen on mesa 10.0 branch.
spec_glsl-1.10_execution_vs-inner-loop-modifies-outer-loop-var also fails by same bisect commit.
spec_EGL_EXT_client_extensions_conformance_test_3 skip by same bisect commit.

Bisect shows: 1032c33cb93f1e8839be0f743b81492c2ca87e39 is the first bad commit.
commit 1032c33cb93f1e8839be0f743b81492c2ca87e39
Author:     Paul Berry <stereotype441@gmail.com>
AuthorDate: Thu Jan 9 11:34:33 2014 -0800
Commit:     Paul Berry <stereotype441@gmail.com>
CommitDate: Tue Jan 21 20:25:52 2014 -0800

    mesa: Change redundant code into loops in texstate.c.

    This is possible now that ctx->Shader.CurrentProgram is an array.

    Reviewed-by: Chris Forbes <chrisf@ijw.co.nz>
    Reviewed-by: Brian Paul <brianp@vmware.com>

output:
Probe color at (0,0)
  Expected: 0.000000 1.000000 0.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
PIGLIT: {'result': 'fail' }


Reproduce steps:
----------------------------
1. xinit
2. ./bin/shader_runner tests/spec/glsl-1.10/execution/vs-call-in-nested-loop.shader_test -auto
Comment 1 Paul Berry 2014-01-24 20:01:36 UTC
I tried to reproduce this on Ironlake using both commit 43e7721 (the latest master) and commit 1032c33 (the bisected commit), and the test passed in both cases.  Also, I'm surprised that a failure in this test would have bisected to this commit, since the commit has to do with texture state, and the test in question doesn't use any textures.

It's possible that this is a sporadic failure, and is not in fact caused by the commit in question.  Can you please retry the bisect to see if that's the case?
Comment 2 lu hua 2014-01-26 01:53:32 UTC
Retest on latest Mesa commit and the bisect commit. It works well.
Close it.
Comment 3 lu hua 2014-01-26 01:53:51 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.