Bug 74491 - check-defs.sh & check-symbols.sh failure on mips/mipsel
Summary: check-defs.sh & check-symbols.sh failure on mips/mipsel
Status: RESOLVED FIXED
Alias: None
Product: HarfBuzz
Classification: Unclassified
Component: src (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 07:03 UTC by Pino Toscano
Modified: 2014-04-10 09:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Ignore _fbss and __bss_start (1.39 KB, text/plain)
2014-02-04 07:03 UTC, Pino Toscano
Details
Ignore _fbss (1.36 KB, patch)
2014-02-22 12:07 UTC, Pino Toscano
Details | Splinter Review

Description Pino Toscano 2014-02-04 07:03:49 UTC
Created attachment 93339 [details]
Ignore _fbss and __bss_start

When enabling the execution of the tests of harfbuzz 0.9.26 at build time in Debian, check-defs.sh and check-symbols.sh failed on mips and mipsel. (This is quite similar to #59637)
The failure logs were like the following:

check-defs.sh:
  Checking that .libs/libharfbuzz.so has the same symbol list as harfbuzz.def
  1a2
  > _fbss
check-symbols.sh:
  Checking that we are not exposing internal symbols
  Processing .libs/libharfbuzz-gobject.so
  _fbss
  Ouch, internal symbols exposed
  Processing .libs/libharfbuzz-icu.so
  _fbss
  Ouch, internal symbols exposed
  Processing .libs/libharfbuzz.so
  _fbss
  Ouch, internal symbols exposed

Other than _fbss, it was reported also __bss_start as internal harfbuzz symbol exported.

I'm proposing to just ignore them like it is done for other libgcc-related symbols, as it was done for #59637 as well; patch attached for it.
Comment 1 Pino Toscano 2014-02-22 12:07:52 UTC
Created attachment 94562 [details] [review]
Ignore _fbss

Sorry, it seems __bss_start is already skipped by the two tests, so only _fbss needs to be; updated patch for just that mips-specific symbol.
Comment 2 Behdad Esfahbod 2014-04-09 23:38:56 UTC
Fixed.  Thanks.
Comment 3 Pino Toscano 2014-04-10 05:55:18 UTC
(In reply to comment #2)
> Fixed.  Thanks.

Forgot to mark this bug as such? :)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.