Bug 74679 - Pyrit crashes with segmentation fault
Summary: Pyrit crashes with segmentation fault
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/r600 (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 15:39 UTC by Nick Zatkovich
Modified: 2014-04-29 21:44 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
This is the output of "R600_DEBUG=cs pyrit selftest", and the piglt all_cl test results of both GPUs (283.76 KB, text/plain)
2014-02-07 15:39 UTC, Nick Zatkovich
Details
Piglit tests on the R9 270x before and after the patch (818.62 KB, application/gzip)
2014-02-08 07:51 UTC, Nick Zatkovich
Details

Description Nick Zatkovich 2014-02-07 15:39:06 UTC
Created attachment 93617 [details]
This is the output of "R600_DEBUG=cs pyrit selftest", and the piglt all_cl test results of both GPUs

OS: Ubuntu 13.10 with Linux kernel 3.13.1
LLVM/Clang: latest git from apt repos, 200925
libclc: git, 20140205
Mesa: git, 201402061930

Graphics card: Radeon R9 270X, aka AMD PITCAIRN

Every time I run a Pyrit selftest, it crashes with a segmentation fault. I have tried this on my laptop with the same setup as above, except this had a Radeon HD 6750M (aka AMD TURKS), and it ran fine.

I have attached the output of "R600_DEBUG=cs pyrit selftest".

I have also attached the output of the piglit all_cl tests for both the 6750M and the R9 270X.
Comment 1 Nick Zatkovich 2014-02-07 15:41:43 UTC
Also, I forgot to mention, I was recompiling pyrit every time I updated any of those repos, and it was from the pyrit svn on google code.
Comment 2 Tom Stellard 2014-02-07 20:51:26 UTC
It works for me with these two patches:
http://people.freedesktop.org/~tstellar/0001-SelectionDAG-Factor-ISD-MUL-lowering-code-out-of-DAG.patch
http://people.freedesktop.org/~tstellar/0002-SelectionDAG-Use-helper-function-to-improve-legaliza.patch

Can you test these?  I have some other uncommitted patches in my tree, so if it still doesn't work for you with these patches, I will push the branch I'm using somewhere so you can test it.
Comment 3 Nick Zatkovich 2014-02-08 07:51:24 UTC
Created attachment 93640 [details]
Piglit tests on the R9 270x before and after the patch
Comment 4 Nick Zatkovich 2014-02-08 07:52:10 UTC
Yes, it works! Thank you. Lets hope these patches land in upstream soon.

for posterity's sake, I've uploaded the piglit tests before and after the patch.
Comment 5 Nick Zatkovich 2014-02-08 18:28:40 UTC
closing this as resolved.
Comment 6 Tom Stellard 2014-02-10 04:43:32 UTC
(In reply to comment #5)
> closing this as resolved.

Let's leave this open until the patches are committed.
Comment 7 Tom Stellard 2014-04-29 21:44:25 UTC
I've committed these fixes to LLVM.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.