Bug 74966 - [i965 10.1 Regression]Piglit/spec/EXT_texture_compression_s3tc/getteximage-targets S3TC 2D_ARRAY fails
Summary: [i965 10.1 Regression]Piglit/spec/EXT_texture_compression_s3tc/getteximage-ta...
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Ian Romanick
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 08:26 UTC by lu hua
Modified: 2014-07-28 02:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2014-02-14 08:26:42 UTC
System Environment:
--------------------------
Platform: Ironlake/Sandybridge/Ivybridge/Haswell/
Libdrm:		(master)libdrm-2.4.52-3-g128e74cf6492025e63e035566bd6e2203e8da5e1
Mesa:		(10.1)62a358892f36b479e0992957a16f1e7c52bce8e2
Xserver:	(server-1.14-branch)xorg-server-1.14.5
Xf86_video_intel:(master)2.99.910-21-g1c5ccf5d9d8beb7e8343eb2d07bbf97f53c1a224
Cairo:		(master)4144307dbfbe7b297135d9ea4b080cae7e06b997
Libva:		(master)b4a4f9b212d8b0bf41a910a85a4898573261d2a7
Libva_intel_driver:(master)54cb60f3d973ce6a908ea57f5aa7481803fe653a
Kernel:	(drm-intel-fixes) cd66407810869709e0d6764409137d48c6812cfc

Bug detailed description:
-----------------------------
It fails on Ironlake/Sandybridge/Ivybridge/Haswell/Baytrail with mesa 10.1 branch. It works well on master and 10.0 branch.
Test Mesa 10.0 branch commit 593484a1c4dd12b5a4f3a7dceae62911a3a07f3e

output:
Testing S3TC.
Testing GL_TEXTURE_2D_ARRAY
GetTexImage() returns incorrect data in byte 0 for layer 0
    corresponding to (0,0), channel 0
    expected: 8
    got: 123
PIGLIT: {'result': 'fail' }

Reproduce steps:
----------------------------
1. xinit
2. ./bin/getteximage-targets S3TC 2D_ARRAY -fbo -auto
Comment 1 Kenneth Graunke 2014-04-16 06:31:30 UTC
I bisected the original failure between 593484a1c4dd12b5a4f3a7dceae62911a3a07f3e and 10.1 to:

commit 2a3d1e2e06ce74801ccbfd349558d44653b9692f
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Wed Nov 20 13:48:36 2013 -0800

    mesa: Remove support for GL_MESA_texture_array
    
    This extension enabled the use of texture array with fixed-function and
    assembly fragment shaders.  No applications are known to use this
    extension.
    
    NOTE: This patch regresses GL_TEXTURE_1D_ARRAY and GL_TEXTURE_2D_ARRAY
    cases of the copyteximage piglit test.  The test is incorrectly using
    texture arrays with fixed function while only requiring the
    GL_EXT_texture_array extension.  A fix for the test has been posted to
    the piglit mailing list.
    
    http://lists.freedesktop.org/archives/piglit/2013-November/008639.html
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>

I haven't bisected between 10.1 and master to find the fix, though.
Comment 2 Kenneth Graunke 2014-04-16 06:41:46 UTC
And I bisected the fix to:

commit b2ad3dbfa436ff205bffca5333ec0061208d52ae
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Mon Dec 16 15:01:54 2013 -0800

    meta: Use GLSL to decompress 2D-array textures
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72582
    Reviewed-by: Eric Anholt <eric@anholt.net>
Comment 3 Kenneth Graunke 2014-04-16 06:47:25 UTC
I'm not sure this is worth fixing.  Backporting the meta changes to 10.1 could be fairly destabilizing.
Comment 4 lu hua 2014-07-28 02:53:36 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.