Bug 74973 - [radeonsi] Gimp OpenCL does not work
Summary: [radeonsi] Gimp OpenCL does not work
Status: NEW
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Radeon (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 99553
  Show dependency treegraph
 
Reported: 2014-02-14 10:57 UTC by darkbasic
Modified: 2018-05-10 18:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dump (8.94 KB, text/plain)
2014-02-19 11:45 UTC, darkbasic
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description darkbasic 2014-02-14 10:57:33 UTC
Start gimp with GEGL_USE_OPENCL=yes
Open an image, tools --> gegl operation --> motion blur --> crash

3.14 and latest graphic stack from git including llvm-3.5 and mesa 10.2
Comment 1 Michel Dänzer 2014-02-17 04:16:31 UTC
Please provide more information about the crash; at least the stderr output from gimp, preferably with R600_DEBUG=cs.
Comment 2 darkbasic 2014-02-19 11:45:16 UTC
Created attachment 94348 [details]
dump

I noticed it suddently started working flawlessly so I asked myself what fixed it: patches from https://bugs.freedesktop.org/show_bug.cgi?id=72785 did fix it.

I currently apply:
0001-SelectionDAG-Factor-ISD-MUL-lowering-code-out-of-DAG.patch
0002-SelectionDAG-Use-helper-function-to-improve-legaliza.patch
0001-R600-SI-Custom-select-64-bit-ADD.patch

Beware that I modified "UP.Threshold = 500" to "UP.Threshold = 100" because "bfgminer --scrypt" didn't work otherwise.

I attached dump from R600_DEBUG=cs GEGL_USE_OPENCL=yes gimp without the patches.
Comment 3 darkbasic 2014-02-19 11:47:36 UTC
Sorry I forgot one patch:
https://bugs.freedesktop.org/attachment.cgi?id=94078

This is the one with "UP.Threshold = 100" instead of "UP.Threshold = 500"
Comment 4 Jan Vesely 2017-01-27 19:02:39 UTC
does GIMP use OpenGL other than GEGL library?
Comment 5 darkbasic 2017-01-27 19:04:31 UTC
Not sure, but I don't think so. AFAIK it' only GEGL-related stuff.
Comment 6 Jan Vesely 2017-01-30 23:04:05 UTC
(In reply to darkbasic from comment #5)
> Not sure, but I don't think so. AFAIK it' only GEGL-related stuff.

a lot of gegl tests pass OK for me on Turks.
notably clone test that includes box-blur and gaussian-blur operations passes OK.

Can you retest with the latest llvm/mesa?
Comment 7 darkbasic 2017-01-31 13:39:32 UTC
I will be able to test within a couple of months, at the moment I don't have access to a pc with such hardware.
Comment 8 Jan Vesely 2018-05-10 18:23:53 UTC
(In reply to darkbasic from comment #7)
> I will be able to test within a couple of months, at the moment I don't have
> access to a pc with such hardware.

Is this still an issue?
gegl testsuite mostly passes with only 3 remaining tests:
contrast-curve -- 7 wrong pixels
clones -- 1 wrong pixel
noise-cell -- fail (many wrong pixels, I think their algorithm is wrong)

comment #2 also mentions that this works OK


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.