Bug 7517 - xdg-desktop-menu --vendor needs work
Summary: xdg-desktop-menu --vendor needs work
Status: RESOLVED FIXED
Alias: None
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: unspecified
Hardware: x86 (IA32) All
: high normal
Assignee: Portland Integration Project
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 7011
  Show dependency treegraph
 
Reported: 2006-07-13 13:14 UTC by Tom Whipple
Modified: 2006-08-03 13:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Tom Whipple 2006-07-13 13:14:14 UTC
The --vendor tag for xdg-desktop-menu works by pre-pending the vendorid to the
filenames of the .desktop/.directory/.menu files. However, the .desktop and
.directory files are also referenced from within the .menu xml. So the author of
the menu file must also know exaclty the syntax xdg-command line at install
time. This seems to place uncessary burden on the .menu author.

There are two obvious approaches to fix this:
1. get rid of the --vendor argument.
2. Make installation of .menu files smart enough to deal with this. This
introduces the dependency that the installation of .menu and .desktop files both
be called with the same arguments. Perhaps we could make it easier by allowing
multiple files for xdg-desktop-menu. (ie xdg-desktop-menu install --user
--vendor shinythings webmirror.*)

In either case, the documentation needs clarifying.

If option 2 is choosen it might be a good idea to generate an error for bad
.menu xml.

The example given as documentation has been fixed and checked in at
portland/xdg-utils/tests/xdg-desktop-menu/data/shinythings_example
Comment 1 Waldo Bastian 2006-07-27 12:49:01 UTC
Proposed solution:
Verify that desktop references in .menu file have a proper vendor prefix.

Should the --vendor argument be mandatory?
Comment 2 Tom Whipple 2006-07-27 14:15:01 UTC
(In reply to comment #1)

Requiring a file to be refered to as 'vendorid-filename.desktop' in the .menu
file but requiring it to be installed via 'install --vendor vendorid
filename.desktop' seems conter-intuitive.

It seems to me the --vendor tag sould be able to edit the menu file or be
removed entirely.

Furthermore, --vendor should only be mandated if it is present and mandated for
all install time utilities to preserve a consistent interface.

Comment 3 Waldo Bastian 2006-08-03 13:28:20 UTC
Fixed for beta 2.
Removed --vendor, check for vendor prefix on input files instead.
Added --novendor to override check.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.