Bug 75528 - export gbm_device_is_format_supported
Summary: export gbm_device_is_format_supported
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Other (show other bugs)
Version: git
Hardware: Other Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 14:22 UTC by Marek Chalupa
Modified: 2014-02-28 22:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
export gbm_device_is_format_supported (785 bytes, patch)
2014-02-26 14:22 UTC, Marek Chalupa
Details | Splinter Review

Description Marek Chalupa 2014-02-26 14:22:16 UTC
Created attachment 94768 [details] [review]
export gbm_device_is_format_supported

Hi,

I was still getting undefined reference to this function when linking against mesa -- but linker found the library and everything. According to nm the function was only local ("t"). Attached patch solved it.

Regards,
Marek Chalupa
Comment 1 Emil Velikov 2014-02-26 20:50:46 UTC
Very nice catch there Marek. Please send the patch to the mesa-dev mailing list for other dev that way be interested.

The patch looks great imho, and unless someone objects I'll commit it by the end of the week.
Comment 2 Emil Velikov 2014-02-28 22:57:51 UTC
Pushed to master

commit 96f324e229d035e6b00e15c96b69a00999d1adcb
Author: Marek Chalupa <mchqwerty@gmail.com>
Date:   Thu Feb 27 09:23:21 2014 +0100

    gbm: export gbm_device_is_format_supported

    Probably depending on compiler settings, the definition can be hidden,
    so undefined reference error can be encountred during linking.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.