Bug 7560 - Build errors with non-64-bit [0.90]
Summary: Build errors with non-64-bit [0.90]
Status: RESOLVED INVALID
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high major
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 7813
  Show dependency treegraph
 
Reported: 2006-07-18 12:41 UTC by Jens Granseuer
Modified: 2010-12-18 01:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
fix byte-swapping for 32-bit (2.04 KB, patch)
2006-07-18 12:43 UTC, Jens Granseuer
Details | Splinter Review
make tools compile (1.40 KB, patch)
2006-07-18 12:45 UTC, Jens Granseuer
Details | Splinter Review

Description Jens Granseuer 2006-07-18 12:41:17 UTC
dbus 0.90 can't be built on systems without 64-bit types. Details to follow...
Comment 1 Jens Granseuer 2006-07-18 12:43:42 UTC
Created attachment 6274 [details] [review]
fix byte-swapping for 32-bit

This patch

a) moves the byte-swapping functions up since we'll otherwise get warnings due
to implicit function declarations

b) replaces use of non-existent swap_8_bytes function by swap_bytes
Comment 2 Jens Granseuer 2006-07-18 12:45:31 UTC
Created attachment 6275 [details] [review]
make tools compile

This patch makes the tools compile with 32-bit. The patch is obviously wrong
and not meant to be applied. It just shows where the issues are. I'm not sure
what the correct fix would look like.
Comment 3 John (J5) Palmieri 2006-11-02 10:23:20 UTC
This patch looks correct.  If you don't have 64bit types then you are in a
special environment and can't accept 64 bit types over the bus.

Havoc do you have any objections to this patch?
Comment 4 Havoc Pennington 2006-11-02 11:03:57 UTC
The first patch looks right and should go in.

The second patch isn't quite right; DBUS_TYPE_INT64 should still be handled / 
assumed to exist if not DBUS_HAVE_INT64 - DBUS_HAVE_INT64 has to do with 
dbus_int64_t, not DBUS_TYPE_INT64. The right thing to do when encountering a 
DBUS_TYPE_INT64 on a platform without dbus_int64_t varies case-by-case.

BTW, what is the system you're using that lacks 64-bit?
Comment 5 Jens Granseuer 2006-11-03 01:05:13 UTC
In the end it turned out the "lack" of 64 bit types was a problem with whatever
autoconf version was used to build the package. Simply rerunning autoconf fixed
the build for me. So, in a way, I was trying to fix someone else's problems, I
guess... ;-)
Comment 6 Ralf Habacker 2010-12-18 01:39:20 UTC
The last comment indicates that this problem isn't a dbus problem and could be closed. Feel free to reopen the bug if required.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.