Bug 75623 - [ivb:gt1 regression] Render corruption (HiZ?)
Summary: [ivb:gt1 regression] Render corruption (HiZ?)
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: medium normal
Assignee: Mika Kuoppala
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 20:44 UTC by Chris Wilson
Modified: 2017-07-24 22:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Revert "drm/i915: enable HiZ Raw Stall Optimization on IVB" (2.15 KB, patch)
2014-03-04 09:43 UTC, Chris Wilson 		no flags Details | Splinter Review
View All

Description Chris Wilson 2014-02-28 20:44:38 UTC 
commit 3fac8978f5d353d350215d7d8dae977d65305f64
Author: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Date:   Thu Jan 30 16:05:48 2014 +0200

    drm/i915: Tune down debug output when context is banned
    
    If we have stopped rings then we know that test is running
    so no need for spam. In addition, only spam when default
    context gets banned.
    
    v2: - make sure default context ban gets shown (Chris)
        - use helper for checking for default context, everywhere (Chris)
    
    v3: - dont be quiet when debug is set (Ben, Daniel)
    
    Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73652
    Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
    Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

seems to be implicated in render corruption of glxgears on an ivg:gt1 1007U

Bizzare.
Comment 1 Chris Wilson 2014-02-28 21:07:17 UTC 
I've run the bisect twice, and manually confirmed the result (3fac8978f vs 3fac8978f^), it does seem to be that commit that introduces the corruption. I suspected the nearby IVB w/a changes, but alas.
Comment 2 Daniel Vetter 2014-03-03 07:56:02 UTC 
Bewildering indeed ... Any change we can blame a difference between driver load and gpu reset on this bug here?
Comment 3 Chris Wilson 2014-03-03 22:01:23 UTC 
Today's attempt:

commit 116f2b6da868dec7539103574d0421cd6221e931
Author: Chia-I Wu <olv@lunarg.com>
Date:   Tue Jan 28 13:29:34 2014 +0800

    drm/i915: enable HiZ Raw Stall Optimization on IVB
    
    The optimization helps IVB too.  No piglit regression.
    
    Signed-off-by: Chia-I Wu <olv@lunarg.com>
    Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>


Which starts to make sense.
Comment 4 Chris Wilson 2014-03-04 09:31:00 UTC 
Reverting 116f2b6da868dec7539103574d0421cd6221e931 on d-i-n fixes the issue.
Comment 5 Chris Wilson 2014-03-04 09:43:45 UTC 
Created attachment 95081 [details] [review]
Revert "drm/i915: enable HiZ Raw Stall Optimization on IVB"
Comment 6 Daniel Vetter 2014-03-04 18:38:45 UTC 
Revert merged, thanks for tracking this down ;-)

commit 0d77df01d342bf3691b1a1ea7d1bf570e31ab94a
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Tue Mar 4 09:41:43 2014 +0000

    Revert "drm/i915: enable HiZ Raw Stall Optimization on IVB"

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.