Created attachment 95165 [details] [review] [PATCH] glib: Use flags argument in poppler_structure_element_get_text() Instead of accepting a boolean argument to enable recursive text extraction, use a flags value argument to poppler_structure_element_get_text(). Text extraction may add features in the future (for example, allowing using alternate text as replacement for inline figures), and this will allow to extend the method without introducing ABI or API breakage.
Comment on attachment 95165 [details] [review] [PATCH] glib: Use flags argument in poppler_structure_element_get_text() Review of attachment 95165 [details] [review]: ----------------------------------------------------------------- ::: glib/poppler-structure-element.cc @@ +666,4 @@ > /** > * poppler_structure_element_get_text: > * @poppler_structure_element: A #PopplerStructureElement > + * @flags: A #PopplerStructureGetTextFlags value, or %0 to disable Yes, this is much better than a boolean parameter, but please, use a value in the enum instead of this 0 here. Something like POPPLER_STRUCTURE_GET_TEXT_NONE
Created attachment 95214 [details] [review] [PATCH v2] glib: Use flags argument in poppler_structure_element_get_text() New version of the patch which adds the POPPLER_STRUCTURE_GET_TEXT_NONE value to the flags enum.
Pushed thanks
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.