It turns out there's a directory where the dbus interface xml files are supposed to be installed: $ ls /usr/share/dbus-1/interfaces/ com.redhat.problems.configuration.ureport.xml org.fedoraproject.Config.Printing.xml org.freedesktop.Accounts.User.xml org.freedesktop.Accounts.xml org.freedesktop.Avahi.AddressResolver.xml org.freedesktop.Avahi.DomainBrowser.xml org.freedesktop.Avahi.EntryGroup.xml org.freedesktop.Avahi.HostNameResolver.xml org.freedesktop.Avahi.RecordBrowser.xml org.freedesktop.Avahi.Server.xml org.freedesktop.Avahi.ServiceBrowser.xml org.freedesktop.Avahi.ServiceResolver.xml org.freedesktop.Avahi.ServiceTypeBrowser.xml org.freedesktop.ColorHelper.xml org.freedesktop.ColorManager.Device.xml org.freedesktop.ColorManager.Profile.xml org.freedesktop.ColorManager.Sensor.xml org.freedesktop.ColorManager.xml org.freedesktop.ModemManager1.Bearer.xml org.freedesktop.ModemManager1.Modem.Firmware.xml org.freedesktop.ModemManager1.Modem.Location.xml org.freedesktop.ModemManager1.Modem.Messaging.xml org.freedesktop.ModemManager1.Modem.Modem3gpp.Ussd.xml org.freedesktop.ModemManager1.Modem.Modem3gpp.xml org.freedesktop.ModemManager1.Modem.ModemCdma.xml org.freedesktop.ModemManager1.Modem.Oma.xml org.freedesktop.ModemManager1.Modem.Signal.xml org.freedesktop.ModemManager1.Modem.Simple.xml org.freedesktop.ModemManager1.Modem.Time.xml org.freedesktop.ModemManager1.Modem.xml org.freedesktop.ModemManager1.Sim.xml org.freedesktop.ModemManager1.Sms.xml org.freedesktop.ModemManager1.xml org.freedesktop.PackageKit.Transaction.xml org.freedesktop.PackageKit.xml org.freedesktop.RealtimeKit1.xml org.freedesktop.UPower.Device.xml org.freedesktop.UPower.KbdBacklight.xml org.freedesktop.UPower.Wakeups.xml org.freedesktop.UPower.xml org.gnome.Shell.Screencast.xml org.gnome.Shell.Screenshot.xml org.gnome.ShellSearchProvider2.xml org.gnome.ShellSearchProvider.xml org.kde.Phonon.AudioOutput.xml wip-org.freedesktop.ModemManager1.Modem.Contacts.xml
Created attachment 95557 [details] [review] Patch
Created attachment 95558 [details] [review] Patch v2
Comment on attachment 95557 [details] [review] Patch Review of attachment 95557 [details] [review]: ----------------------------------------------------------------- Looks good otherwise but I think we should now version them too (in a separate patch).
Comment on attachment 95558 [details] [review] Patch v2 Review of attachment 95558 [details] [review]: ----------------------------------------------------------------- This version looks better, yes :) ::: src/Makefile.am @@ -8,4 @@ > SUBDIRS += geoip-server > endif # BUILD_GEOIP_SERVER > > -interfacedir = $(datadir)/geoclue-$(GEOCLUE_API_VERSION) Please make sure to use GEOCLUE_API_VERSION variable to version the interface files.
Created attachment 95576 [details] [review] Rename dbus interface files as per convention Other projects that install files in /usr/share/dbus-1/interfaces/ name the files according to the names of the dbus interfaces. Do the same here and rename the interface description xml files to org.freedesktop.GeoClue2.xml and org.freedesktop.GeoClue2.Agent.xml.
Created attachment 95577 [details] [review] Move dbus interface xml files to their canonical location Install them to /usr/share/dbus-1/interfaces/. At the same time, also rename the files as per convention: instead of geoclue-interface.xml and geoclue-agent-interface.xml, rename them to org.freedesktop.GeoClue2.xml and org.freedesktop.GeoClue2.Agent.xml, respectfully. This shouldn't require any changes in apps using geoclue since they use pkgconfig to get the paths of the interface descrition files.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.