Bug 764 - Xprt permanently resets itself after each client disconnect
Summary: Xprt permanently resets itself after each client disconnect
Status: RESOLVED FIXED
Alias: None
Product: xprint
Classification: Unclassified
Component: Server: Config: startup scripts (show other bugs)
Version: unspecified
Hardware: All All
: high critical
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-19 00:30 UTC by Roland Mainz
Modified: 2004-06-19 00:52 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch for 2004-06-18-oldcvs_trunk (9.41 KB, patch)
2004-06-19 00:32 UTC, Roland Mainz
no flags Details | Splinter Review
Patch for 2004-06-18-trunk (6.06 KB, patch)
2004-06-19 01:59 UTC, Roland Mainz
no flags Details | Splinter Review
Refix for 2004-06-18-oldcvs_trunk (9.48 KB, patch)
2004-06-19 14:27 UTC, Roland Mainz
no flags Details | Splinter Review
Refix for 2004-06-18-trunk (12.41 KB, patch)
2004-06-19 14:54 UTC, Roland Mainz
no flags Details | Splinter Review
Fix for oldcvs_trunk RPM build bustage (1.28 KB, patch)
2004-06-19 17:50 UTC, Roland Mainz
no flags Details | Splinter Review

Description Roland Mainz 2004-06-19 00:30:00 UTC
Xprt permanently resets itself after each client disconnect if there is only one
client which uses the print server.

Unfortunately this has a couple of unwanted side-effects:
- Font paths set after Xprt startup via "xset +fp ..." get lost (there are a
bunch of complains of Debian people who hit that problem... ;-()
- Resources stored in the Xserver get lost
- Displaying a print dialog is awfull slow
Comment 1 Roland Mainz 2004-06-19 00:32:28 UTC
Created attachment 379 [details] [review]
Patch for 2004-06-18-oldcvs_trunk

Note that the patch backports the "-noreset" option of Xfree86 to the old
codebase.
Comment 2 Roland Mainz 2004-06-19 00:34:10 UTC
attachment 379 [details] [review] checked-in...

/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/Xprint/etc/init.d/xprint,v 
<--  xprint
new revision: 1.53; previous revision: 1.52
/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/dix/dispatch.c,v  <-- 
dispatch.c
new revision: 1.3; previous revision: 1.2
/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/os/utils.c,v  <-- 
utils.c
new revision: 1.6; previous revision: 1.5
Comment 3 Roland Mainz 2004-06-19 01:59:16 UTC
Created attachment 380 [details] [review]
Patch for 2004-06-18-trunk
Comment 4 Roland Mainz 2004-06-19 02:02:26 UTC
attachment 380 [details] [review] checked-in into Xorg trunk...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.64; previous revision: 1.63
/cvs/xorg/xc/programs/Xserver/Xprint/etc/init.d/xprint,v  <--  xprint
new revision: 1.9; previous revision: 1.8
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.
Comment 5 Roland Mainz 2004-06-19 02:04:19 UTC
Alan:
Is there a chanche to get the "-noreset" option implemented into the Solaris
Xserver's (Xsun, Xprt, etc), too ? Then there would no need anymore to add a
special case for /usr/openwin/bin/Xprt (which still suffers from the problems
described in comment #0 due lack of a -noreset option...). ?
Comment 6 Alan Coopersmith 2004-06-19 02:24:19 UTC
We can't add -noreset to the Solaris servers right now (we're in feature freeze),
but this shouldn't be a problem for the Solaris Xprt in Solaris 9 and later, since
the Solaris Xprt was changed in Solaris 9 to effectively do the same thing for
Xprt.
Comment 7 Roland Mainz 2004-06-19 14:25:34 UTC
Alan Coopersmith wrote:
> the Solaris Xprt was changed in Solaris 9 to effectively do the same thing for
> Xprt.

Does it simply not reset or is that something like a "delayed" reset (e.g.
"reset only if the last client has left the boat and nothing has happend for
20secs") ?
Comment 8 Roland Mainz 2004-06-19 14:26:15 UTC
I'll reopen the bug and adjust the Xserver code to default to "-noreset" for
Xprt.
Comment 9 Roland Mainz 2004-06-19 14:27:14 UTC
Created attachment 381 [details] [review]
Refix for 2004-06-18-oldcvs_trunk
Comment 10 Roland Mainz 2004-06-19 14:29:10 UTC
attachment 381 [details] [review] checked-in...

/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/Xprint/etc/init.d/xprint,v 
<--  xprint
new revision: 1.54; previous revision: 1.53
/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/dix/dispatch.c,v  <-- 
dispatch.c
new revision: 1.4; previous revision: 1.3
/cvs/xprint/xprint/src/xprint_main/xc/programs/Xserver/os/utils.c,v  <-- 
utils.c
new revision: 1.7; previous revision: 1.6
Comment 11 Roland Mainz 2004-06-19 14:54:12 UTC
Created attachment 382 [details] [review]
Refix for 2004-06-18-trunk
Comment 12 Roland Mainz 2004-06-19 14:57:24 UTC
attachment. 382 checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.65; previous revision: 1.64
/cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v  <--  Init.c
new revision: 1.5; previous revision: 1.4
/cvs/xorg/xc/programs/Xserver/Xprint/etc/init.d/xprint,v  <--  xprint
new revision: 1.10; previous revision: 1.9
/cvs/xorg/xc/programs/Xserver/os/utils.c,v  <--  utils.c
new revision: 1.3; previous revision: 1.2
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED again.
Comment 13 Roland Mainz 2004-06-19 17:50:24 UTC
Created attachment 385 [details] [review]
Fix for oldcvs_trunk RPM build bustage
Comment 14 Roland Mainz 2004-06-19 17:52:39 UTC
Roland Mainz wrote:
> reated an attachment (id=385)
> Fix for oldcvs_trunk RPM build bustage

Sorry... that was the wrong bugid... the patch was for bug 765 (that mess
happens when too many browser windows are open... ;-/) ...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.