Bug 76495 - #!/usr/bin/python in testsuite
Summary: #!/usr/bin/python in testsuite
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other FreeBSD
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-03-23 06:08 UTC by Ting-Wei Lan
Modified: 2014-05-12 07:28 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
stop hardcoding python's path in .py scripts (4.74 KB, patch)
2014-05-08 13:19 UTC, Guillaume Desmottes
Details | Splinter Review

Description Ting-Wei Lan 2014-03-23 06:08:37 UTC
Some system may not have python installed in /usr/bin. Can we change it to /usr/bin/env python or @PYTHON@?

I found this problem in tests/all-errors-documented.py.
Comment 1 Guillaume Desmottes 2014-05-07 12:20:58 UTC
I usually use "#!/usr/bin/env python". Is that the proper way to go?
Comment 2 Simon McVittie 2014-05-07 16:35:08 UTC
(In reply to comment #1)
> I usually use "#!/usr/bin/env python". Is that the proper way to go?

Seems reasonable.
Comment 3 Ting-Wei Lan 2014-05-07 16:40:28 UTC
(In reply to comment #1)
> I usually use "#!/usr/bin/env python". Is that the proper way to go?

Some distribution uses python3 as python, so using "#!/usr/bin/env python2" may be better.
Comment 4 Guillaume Desmottes 2014-05-08 13:19:24 UTC
Created attachment 98686 [details] [review]
stop hardcoding python's path in .py scripts
Comment 5 Simon McVittie 2014-05-09 14:05:06 UTC
Comment on attachment 98686 [details] [review]
stop hardcoding python's path in .py scripts

Review of attachment 98686 [details] [review]:
-----------------------------------------------------------------

Ship it.
Comment 6 Guillaume Desmottes 2014-05-12 07:28:15 UTC
Merged to master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.