Bug 76855 - [next] Put low-level/murky APIs in -dbus library, and delete -core
Summary: [next] Put low-level/murky APIs in -dbus library, and delete -core
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard: review?
Keywords: patch
Depends on: 28782
Blocks: 68660 76369
  Show dependency treegraph
 
Reported: 2014-03-31 18:04 UTC by Simon McVittie
Modified: 2014-04-07 17:30 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2014-03-31 18:04:47 UTC
+++ This bug was initially created as a clone of Bug #76369 +++

Various murky helper APIs like tp_g_value_slice_new_* can safely move into the -dbus sub-library where we're more free to break their ABIs.

After hacking on this for a bit, it turns out to be entirely possible to delete the -core library altogether, and just have -dbus and "main", which is nice.
Comment 2 Simon McVittie 2014-04-02 20:00:14 UTC
I intend for this to be my next "port all the things" effort, then the client side of Bug #76369 after that.
Comment 3 Simon McVittie 2014-04-03 12:01:56 UTC
Compile-tested only, since this shouldn't affect runtime behaviour at all, as long as things compile, and the most likely place for runtime failures is in Empathy which doesn't have automated tests. I'll do manual testing once I've landed some more de-GVariantification, since it currently takes quite a lot of compiling to set up for that.

telepathy-glib:
http://cgit.freedesktop.org/~smcv/telepathy-glib/log?h=next-decore

MC did not need changes.

CMs:
http://cgit.freedesktop.org/~smcv/telepathy-salut/log?h=next-decore
http://cgit.freedesktop.org/~smcv/telepathy-haze/log?h=next-decore
http://cgit.freedesktop.org/~smcv/telepathy-idle/log?h=next-decore
http://cgit.freedesktop.org/~smcv/telepathy-rakia/log?h=next-decore
http://cgit.freedesktop.org/~smcv/telepathy-gabble/log/?h=next-decore&update=yes-please

Clients:
http://cgit.freedesktop.org/~smcv/folks/log?h=next-decore
TPAW did not need changes.
http://cgit.freedesktop.org/~smcv/empathy/log?h=next-decore
Comment 4 Xavier Claessens 2014-04-03 13:11:54 UTC
+1 to all
Comment 5 Simon McVittie 2014-04-07 17:30:51 UTC
Fixed in 0.99.10


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.