Bug 76926 - [Bisected]Ogles1conform gets.c fails
Summary: [Bisected]Ogles1conform gets.c fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i915 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-02 02:14 UTC by lu hua
Modified: 2014-04-08 01:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2014-04-02 02:14:02 UTC
System Environment:
--------------------------
Platform: Ivybridge
Libdrm:		(master)libdrm-2.4.52-10-g1cb5fc706cf5913d9dee33c939f65a23ecea17a5
Mesa:		(master)5d76e4464323fd72af8bd5e455638004a6379e21
Xserver:	(master)xorg-server-1.15.99.901-169-g9d20d18fb9dcc74bfa5392a2da40fd41b3e640d3
Xf86_video_intel:(master)2.99.911-33-ga926d9f68231ac0f2a1f54c7a722979a8ed6e9e1
Cairo:		(master)bb17403622e9ea474017e0039af8ee48b2b285db
Libva:		(staging)238b914bba8cc41076c14eb2d37938f2f705e78f
Libva_intel_driver:(staging)150f67c67bd92cd201b75a92388fe3a63b00cd8a
Kernel:	(drm-intel-nightly)346aad79969a02f2b9fc77bdade02c7413f42ea9

Bug detailed description:
-----------------------------
It fails on all platforms with mesa master branch, and works well on 10.1 branch.
Following cases also fail with same bisect commit:
bufobj.c
mustpass.c
pntszary.c

Bisect shows: 1a59f9a131318e1239b47b9ea4fe7c84f461cf37 is the first bad commit
commit 1a59f9a131318e1239b47b9ea4fe7c84f461cf37
Author:     Ian Romanick <ian.d.romanick@intel.com>
AuthorDate: Wed Mar 26 12:57:47 2014 -0700
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Mon Mar 31 14:47:00 2014 -0700

    mapi_abi: Make ES1 and ES2 static_dispatch=false functions hidden

    This has been a long standing issue with the ES libraries.  Functions
    marked in the XML with 'static_dispatch=false' were still incorrectly
    exported.  ABI-check is supposed to detect this case, but we have to
    paper over failures every time a new extension is added.

    This change will cause a big pile of functions to disappear from
    libGLESv2 and libGLESv1_CM.


output:
form -s -v 2 -1 gets.c
OpenGL ES Conformance Test
Version 1.1 revision 1 (2005/07/08)

Setup Report.
    GL_VERSION = OpenGL ES-CM 1.1 Mesa 10.2.0-devel (git-1a59f9a)
    GL_VENDOR = Intel Open Source Technology Center
    GL_RENDERER = Mesa DRI Intel(R) Ivybridge Desktop
    GL_EXTENSIONS = GL_EXT_blend_minmax GL_EXT_multi_draw_arrays GL_EXT_texture_                                                                                                 filter_anisotropic GL_EXT_texture_lod_bias GL_OES_byte_coordinates GL_OES_fixed_                                                                                                 point GL_OES_stencil_wrap GL_OES_compressed_paletted_texture GL_OES_query_matrix                                                                                                  GL_OES_read_format GL_OES_single_precision GL_EXT_texture_compression_dxt1 GL_O                                                                                                 ES_draw_texture GL_OES_point_size_array GL_OES_point_sprite GL_EXT_texture_forma                                                                                                 t_BGRA8888 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth24 GL_OES_element_ind                                                                                                 ex_uint GL_OES_fbo_render_mipmap GL_OES_framebuffer_object GL_OES_mapbuffer GL_O                                                                                                 ES_rgb8_rgba8 GL_OES_stencil8 GL_OES_texture_env_crossbar GL_OES_texture_mirrore                                                                                                 d_repeat GL_OES_texture_npot GL_OES_EGL_image GL_OES_packed_depth_stencil GL_OES                                                                                                 _texture_cube_map GL_APPLE_texture_max_level GL_EXT_discard_framebuffer GL_EXT_r                                                                                                 ead_format_bgra GL_OES_blend_equation_separate GL_OES_blend_func_separate GL_OES                                                                                                 _blend_subtract GL_OES_EGL_image_external GL_OES_vertex_array_object GL_ANGLE_te                                                                                                 xture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_EXT_map_buffer_range                                                                                                  GL_OES_surfaceless_context
    Verbose level = 2.
    Random number seed = 1.
    Path inactive.

Config Report.
    Config ID = 14.
    RGBA (8, 8, 8, 8).

Epsilon Report.
    zero error epsilon = 0.000122.
    RGBA error epsilon = 0.00404, 0.00404, 0.00404, 0.00404.

Gets test/GFX/Test/Ogles1conform/ogles1conform/es1/conform/conform/conform: symb                                                                                                 ol lookup error: /GFX/Test/Ogles1conform/ogles1conform/es1/conform/conform/confo                                                                                                 rm: undefined symbol: glPointSizePointerOES


Reproduce steps:
---------------------------- 
1. xinit
2. ./conform -s -v 2 -1 gets.c
Comment 1 Ian Romanick 2014-04-02 04:39:25 UTC
Patch sent to mesa-dev:

http://lists.freedesktop.org/archives/mesa-dev/2014-April/056986.html

The test mentioned below passes now, but pntszary.c fails.  Did pntszary.c previously pass?

NOTE: This patch will likely require the other patch series that I sent to mesa-dev earlier.  See bug #76869.
Comment 2 lu hua 2014-04-02 05:49:15 UTC
(In reply to comment #1)
> Patch sent to mesa-dev:
> 
> http://lists.freedesktop.org/archives/mesa-dev/2014-April/056986.html
> 
> The test mentioned below passes now, but pntszary.c fails.  Did pntszary.c
> previously pass?
> 
> NOTE: This patch will likely require the other patch series that I sent to
> mesa-dev earlier.  See bug #76869.

Test this patch and https://bugs.freedesktop.org/show_bug.cgi?id=76869#c8 patches, It works well.

pntszary.c always fails.

output on the bisected commit:
OpenGL ES Conformance Test
Version 1.1 revision 1 (2005/07/08)

Setup Report.
    GL_VERSION = OpenGL ES-CM 1.1 Mesa 10.2.0-devel (git-5d76e44)
    GL_VENDOR = Intel Open Source Technology Center
    GL_RENDERER = Mesa DRI Intel(R) Ironlake Desktop
    GL_EXTENSIONS = GL_EXT_blend_minmax GL_EXT_multi_draw_arrays GL_EXT_texture_filter_anisotropic GL_EXT_texture_lod_bias GL_OES_byte_coordinates GL_OES_fixed_point GL_OES_stencil_wrap GL_OES_compressed_paletted_texture GL_OES_query_matrix GL_OES_read_format GL_OES_single_precision GL_EXT_texture_compression_dxt1 GL_OES_draw_texture GL_OES_point_size_array GL_OES_point_sprite GL_EXT_texture_format_BGRA8888 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth24 GL_OES_element_index_uint GL_OES_fbo_render_mipmap GL_OES_framebuffer_object GL_OES_mapbuffer GL_OES_rgb8_rgba8 GL_OES_stencil8 GL_OES_texture_env_crossbar GL_OES_texture_mirrored_repeat GL_OES_texture_npot GL_OES_EGL_image GL_OES_packed_depth_stencil GL_OES_texture_cube_map GL_APPLE_texture_max_level GL_EXT_discard_framebuffer GL_EXT_read_format_bgra GL_OES_blend_equation_separate GL_OES_blend_func_separate GL_OES_blend_subtract GL_OES_EGL_image_external GL_OES_vertex_array_object GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_EXT_map_buffer_range GL_OES_surfaceless_context
    Verbose level = 2.
    Random number seed = 1.
    Path inactive.

Config Report.
    Config ID = 10.
    RGBA (8, 8, 8, 8).

Epsilon Report.
    zero error epsilon = 0.000122.
    RGBA error epsilon = 0.00404, 0.00404, 0.00404, 0.00404.

Point Size Array test/GFX/Test/Ogles1conform/ogles1conform/es1/conform/conform/conform: symbol lookup error: /GFX/Test/Ogles1conform/ogles1conform/es1/conform/conform/conform: undefined symbol: glPointSizePointerOES

It always has this fail:
Conform (single precision) failed.
    Point Size Array test (Test number #66) failed.
******************** SUMMARY OF 'conform' RESULTS ********************
SUMMARY: Point Size Array test (#66) failed 6 times at path level 0.
SUMMARY: 1 test failed across all configs at path level 0.
SUMMARY: 6 conformant configs, 0 non-conformant configs.
****************** END SUMMARY OF 'conform' RESULTS ******************
Comment 3 Ian Romanick 2014-04-02 18:42:25 UTC
Fixed by:

commit 5a68f731029258ddede4bd5d578cee203f4a80b3
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Apr 1 21:32:11 2014 -0700

    glapi: Add static dispatch for glPointSizePointerOES
    
    The OpenGL ES 1.1 conformance tests expect this function to be
    statically available form libGLESv1_CM.so.  The comment "required for
    es1.1" in the XML file should have been a clue.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76926
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Tested-by: Lu Hua <huax.lu@intel.com>
Comment 4 lu hua 2014-04-08 01:35:05 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.