telepathy-glib/capabilities.c: /* ContactSearch channel should have ChannelType and TargetEntityType=NONE * but CM implementations are wrong and omitted TargetEntityType, * so it's set in stone now. */ if (g_hash_table_size (fixed) != 1) continue; I think we already changed the 1.x spec to fix that. We should change TpCapabilities and any connection managers that support ContactSearch so they put TargetEntityType=NONE in their requestable channel classes. This would be a good bite-sized bug if someone has a Telepathy build environment and a few minutes.
Created attachment 98967 [details] [review] [tp-glib] allow CMs to put 'TargetEntityType=None' in contact search requests
Created attachment 98968 [details] [review] [gabble] search-manager: use properties constants
Created attachment 98969 [details] [review] [gabble] search-manager: use tp_asv_new()
Created attachment 98970 [details] [review] [gabble] search-manager: allow user to pass TargetEntityType=NONE when requesting
Comment on attachment 98967 [details] [review] [tp-glib] allow CMs to put 'TargetEntityType=None' in contact search requests Review of attachment 98967 [details] [review]: ----------------------------------------------------------------- Looks good, although a regression test would be nice. ::: telepathy-glib/capabilities.c @@ +920,5 @@ > continue; > > + entity_type = tp_vardict_get_uint32 (fixed, > + TP_PROP_CHANNEL_TARGET_ENTITY_TYPE, &valid); > + /* If TargetEntityType is missing we threat it as NONE */ treat A threat is something rather different :-)
Comment on attachment 98968 [details] [review] [gabble] search-manager: use properties constants Review of attachment 98968 [details] [review]: ----------------------------------------------------------------- Sure
Comment on attachment 98969 [details] [review] [gabble] search-manager: use tp_asv_new() Review of attachment 98969 [details] [review]: ----------------------------------------------------------------- Yes, for next
Comment on attachment 98970 [details] [review] [gabble] search-manager: allow user to pass TargetEntityType=NONE when requesting Review of attachment 98970 [details] [review]: ----------------------------------------------------------------- Looks good for 'next'. Are there any other CMs that implement ContactSearch? If not, this can be closed when these are merged.
Fixed & merged.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.