Bug 77092 - backlight: clamp_brightness not suitable for devices in led subsystem (kbd backlight)
Summary: backlight: clamp_brightness not suitable for devices in led subsystem (kbd ba...
Status: RESOLVED FIXED
Alias: None
Product: systemd
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: systemd-bugs
QA Contact: systemd-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-05 20:21 UTC by Thomas Lercher
Modified: 2014-06-10 16:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
execute clamp_brightness only for non LED devices (900 bytes, patch)
2014-04-06 12:02 UTC, Thomas Lercher
Details | Splinter Review

Description Thomas Lercher 2014-04-05 20:21:08 UTC
The clamp_brightness function introduced with systemd-212 should be disabled for devices that resides in the LED subsystem (which are according to 99-systemd.rules.in are only keyboard backlights).

People that turn their kbd backlight off, usually want the same state after a reboot/service-restart.


Sorry for not attaching a PATCH-File at all, i'm not really a C developer)
Comment 1 Thomas Lercher 2014-04-06 12:02:04 UTC
Created attachment 96977 [details] [review]
execute clamp_brightness only for non LED devices

Related my prior comment with a patch.. i've created one, hope he is fine.
Comment 2 Josh Triplett 2014-06-02 14:35:33 UTC
(In reply to comment #1)
> Created attachment 96977 [details] [review] [review]
> execute clamp_brightness only for non LED devices
> 
> Related my prior comment with a patch.. i've created one, hope he is fine.

This patch looks reasonable to me.

I do wonder, though, if it might make more sense to whitelist only the subsystem used for display backlights, rather than blacklisting LED "backlights".
Comment 3 Lennart Poettering 2014-06-10 16:58:25 UTC
Fixed in git!

Thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.