Bug 78076 - Please add support for grp:lwin_space_toggle and similar
Summary: Please add support for grp:lwin_space_toggle and similar
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 12:20 UTC by Dimitri John Ledkov
Modified: 2014-05-06 22:33 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
add grp:win_space_toggle to allow meta keys to switch keyboard layout (2.17 KB, patch)
2014-05-01 14:39 UTC, Maarten Lankhorst
Details | Splinter Review
Missing PC_SUPER_LEVEL2 definition. (523 bytes, patch)
2014-05-05 08:33 UTC, Maarten Lankhorst
Details | Splinter Review

Description Dimitri John Ledkov 2014-04-29 12:20:38 UTC
Gnome3, Unity, Mac OS X and Windows default to using "Super+Space" (aka win+space,logo+space, etc) combination to switch keyboard layouts.

I've tried to get "Super+Space" key to work with xkeyboard-config and it doesn't appear to work. (Such that the key-combination to change layouts is consistent everywhere)

xkeyboard-config manpage only offers:
grp:alt_space_toggle        Alt+Space
grp:lwin_toggle             Left Win
grp:rwin_toggle             Right Win

But ideally it is desired to also offer following options:
grp:lwin_space_toggle             Left Win + Space
grp:rwin_space_toggle             Right Win + Space

Bruteforcing / setting above by chance did not work =)

Can those two options be added?
Comment 1 Maarten Lankhorst 2014-05-01 14:39:16 UTC
Created attachment 98299 [details] [review]
add grp:win_space_toggle to allow meta keys to switch keyboard layout

I've attached my patch. But I have no clue about xkb-data, so I don't know if it's correct or not. Could this be reviewed?
Comment 2 Sergey V. Udaltsov 2014-05-01 22:57:34 UTC
Dimitri, would you be able to confirm this patch is ok for you?
Comment 3 Dimitri John Ledkov 2014-05-01 23:04:59 UTC
(In reply to comment #2)
> Dimitri, would you be able to confirm this patch is ok for you?

Yes, the proposed patch works great for my use cases.
Comment 4 Sergey V. Udaltsov 2014-05-01 23:14:30 UTC
fine, thanks, committed to git.
Comment 5 Maarten Lankhorst 2014-05-05 08:33:23 UTC
Created attachment 98456 [details] [review]
Missing PC_SUPER_LEVEL2 definition.

It looks like the PC_SUPER_LEVEL2 definition is missing from the commit, I've attached it as diff.
Comment 6 Sergey V. Udaltsov 2014-05-06 22:33:14 UTC
right, thank you!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.