Bug 78095 - Mesa: --enable-llvm-shared-libs option only works if it's omitted
Summary: Mesa: --enable-llvm-shared-libs option only works if it's omitted
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: 10.1
Hardware: Other All
: medium normal
Assignee: mesa-dev
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 20:57 UTC by Erich Seifert
Modified: 2014-04-29 21:22 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
mesa-10.1.1-llvm-shared-libs.patch (1.59 KB, patch)
2014-04-29 21:05 UTC, Erich Seifert
Details | Splinter Review

Description Erich Seifert 2014-04-29 20:57:06 UTC
If --enable-llvm-shared-libs option is passed Mesa builds without shared libs, it only works correctly when the option is omitted.

Commit 933215ac63e43c7960e8e71f42748007ce810df7 changed --with-llvm-shared-libs to --enable-llvm-shared-libs, but still relies on the variable with_llvm_shared_libs which isn't set if AC_ARG_ENABLE is used.
Comment 1 Erich Seifert 2014-04-29 21:05:23 UTC
Created attachment 98195 [details] [review]
mesa-10.1.1-llvm-shared-libs.patch

Added a patch which tries to fix llvm-shared-libs. It assigns the variable enable_llvm_shared_libs if --enable-llvm-shared-libs is set, or if it's omitted.
Comment 2 Erich Seifert 2014-04-29 21:22:29 UTC
I just realized that the issue has already been fixed in git by commit 065b6ca52b6a34b1fa6713f41641738401e47710.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.