Bug 78269 - [All Regression]igt/testdisplay unable to exit sporadically
Summary: [All Regression]igt/testdisplay unable to exit sporadically
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Jesse Barnes
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 03:23 UTC by Guo Jinxian
Modified: 2017-10-06 14:38 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (76.59 KB, text/plain)
2014-05-05 03:23 UTC, Guo Jinxian
no flags Details

Description Guo Jinxian 2014-05-05 03:23:10 UTC
Created attachment 98442 [details]
dmesg

*System Environment:
--------------------------
Platform: All
kernel: 
-nightly: 08ce6614d07dd1e426109672a5e323317c8d6ec7(fails)
-queued: e5c03ca362819ba8ffbe5674340b61b9cd75de8f (fails)
-fixes: 9bbfd20abe5025adbb0ac75160bd2e41158a9e83 (fails)


 *Bug detailed description:
-----------------------------
igt/testdisplay unable to exit sporadically

Output:
[root@x-pnv2 tests]# ./testdisplay
CRTC(7):[0]  1024x600 60 1024 1072 1104 1200 600 603 609 625 0xa 0x48 45000
[root@x-pnv2 tests]# [root@x-pnv2 tests]# [root@x-pnv2 tests]# [root@x-pnv2 tests]#

*Reproduce steps:
---------------------------- 
1. login the test machine by ssh
2. ./testdisplay
3. Press "enter" on keyboard, the cursor unable line-feed.
4. Input "exit" to logout the terminal and ssh in again, the operation will recover
Comment 1 Daniel Vetter 2014-05-05 06:52:07 UTC
Is this a regression?
Comment 2 Guo Jinxian 2014-05-05 09:51:32 UTC
(In reply to comment #1)
> Is this a regression?

Yes, It's a igt regression issue, but some commit unable to make.

The first bad commit could be any of:
3d9e63f2ad0c676b3efba4c854ef645ae60ee7e1
7255a84c9c8f4d46b47d490331100a11179180a1
7568edf4b1dd0f8c1b061a2bb53d593ff9d4d33d
896b550984cf3ffd0fa67051d5b9cf0239634894
ae461e67e8816aa7cd80791216a839d92e04f0e5
669a2fca6c5ccd256d2d767107963840f7de438e
c6c2b2bb7039e8cc89841bd9782a61b7d734dfe2
64401f57e958998d537ff67525d5f1e9a4f76b22
961a46c82b4fe558ea726833aa9d390382742a10
9048aa1974aee567617220f9685ad115be0cbae7
We cannot bisect more!
Comment 3 Guo Jinxian 2014-05-06 01:31:34 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Is this a regression?
> 
> Yes, It's a igt regression issue, but some commit unable to make.
> 
> The first bad commit could be any of:
> 3d9e63f2ad0c676b3efba4c854ef645ae60ee7e1
> 7255a84c9c8f4d46b47d490331100a11179180a1
> 7568edf4b1dd0f8c1b061a2bb53d593ff9d4d33d
> 896b550984cf3ffd0fa67051d5b9cf0239634894
> ae461e67e8816aa7cd80791216a839d92e04f0e5
> 669a2fca6c5ccd256d2d767107963840f7de438e
> c6c2b2bb7039e8cc89841bd9782a61b7d734dfe2
> 64401f57e958998d537ff67525d5f1e9a4f76b22
> 961a46c82b4fe558ea726833aa9d390382742a10
> 9048aa1974aee567617220f9685ad115be0cbae7
> We cannot bisect more!

I tried to revert these commits one by one, and found that7255a84c9c8f4d46b47d490331100a11179180a1 maybe the first bad commit.

commit 7255a84c9c8f4d46b47d490331100a11179180a1
Author:     Jesse Barnes <jbarnes@virtuousgeek.org>
AuthorDate: Wed Mar 26 11:02:48 2014 -0700
Commit:     Jesse Barnes <jbarnes@virtuousgeek.org>
CommitDate: Wed Mar 26 11:13:23 2014 -0700

    testdisplay: make termio unbuffered

    So hotkeys take effect immediately.
Comment 4 Jesse Barnes 2014-05-15 18:40:37 UTC
yeah I'm not handling some error path correctly and restoring the termio configuration.  This is a test bug, not a kernel bug.
Comment 5 Imre Deak 2014-05-15 19:46:09 UTC
(In reply to comment #4)
> yeah I'm not handling some error path correctly and restoring the termio
> configuration.  This is a test bug, not a kernel bug.

Jesse, note that I pushed some fix recently to restore the termio during signal and normal exit. Not sure if it fixes this bug though.
Comment 6 Daniel Vetter 2014-05-15 21:24:21 UTC
Guo, can you please retest with latest igt to check whether Imre has fixed the regression already?
Comment 7 Guo Jinxian 2014-05-21 01:27:22 UTC
(In reply to comment #6)
> Guo, can you please retest with latest igt to check whether Imre has fixed
> the regression already?

This issue unable to reproduce with latest igt(c75dcbdac51dcc2d631a4a45049c9421e0229e16).
Comment 8 Daniel Vetter 2014-05-22 07:44:12 UTC
Cool, sounds like Imre's fix works.
Comment 9 liulei 2014-05-26 07:33:42 UTC
Verified
[root@x-hswu opt]# ./testdisplay
CRTC(5):[0]  1366x768 60 1366 1404 1426 1592 768 771 777 790 0xa 0x48 75600
[root@x-hswu opt]#
[root@x-hswu opt]#
[root@x-bdw opt]# ./testdisplay
CRTC(5):[0]  1920x1080 60 1920 1966 1996 2080 1080 1082 1086 1112 0xa 0x48 138780
[root@x-bdw opt]#
[root@x-bdw opt]#
Comment 10 Elizabeth 2017-10-06 14:38:19 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.