Created attachment 98659 [details] dmesg *System Environment: -------------------------- Regression: No. The cases always skipped Non-working platforms: BDW *kernel: -------------------------- -nightly: 5e83a7964e9530e6f693a3d49adccceb7a4b86e1 (fails) -queued: d9ceb957fd97836c7fb0e403062e68ad2f737021 (fails) Author: Ben Widawsky <benjamin.widawsky@intel.com> Date: Mon Apr 28 17:18:28 2014 -0700 drm/i915: Support 64b relocations All the rest of the code to enable this is in my branch. Without my branch, hitting > 32b offsets is impossible. The code has always "supported" 64b, but it's never actually been run of tested. This change doesn't actually fix anything. [1] I am not sure why X won't work yet. I do not get hangs or obvious errors. There are 3 fixes grouped together here. First is to remove the hardcoded 0 for the upper dword of the relocation. The next fix is to use a 64b value for target_offset. The final fix is to not directly apply target_offset to reloc->delta. reloc->delta is part of ABI, and so we cannot change it. As it stands, 32b is enough to represent everything we're interested in representing anyway. The main problem is, we cannot add greater than 32b values to it directly. [1] Almost all of intel-gpu-tools is not yet ready to test 64b relocations. There are a few places that expect 32b values for offsets and these all won't work. Cc: Rafael Barbalho <rafael.barbalho@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Ben Widawsky <ben@bwidawsk.net> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> -fixes: 9bbfd20abe5025adbb0ac75160bd2e41158a9e83 (fails) Author: Paulo Zanoni <paulo.r.zanoni@intel.com> Date: Tue Apr 29 11:00:22 2014 -0300 drm/i915: don't try DP_LINK_BW_5_4 on HSW ULX Because the docs say ULX doesn't support it on HSW. Reviewed-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> *Bug detailed description: ----------------------------- FBC was enabled on BDW by default, Some subcases of igt/kms_fbc_crc still skip Output: ./kms_fbc_crc IGT-Version: 1.6-g7935bbd (x86_64) (Linux: 3.15.0-rc3_drm-intel-next-queued_bf67a6_20140507+ x86_64) Beginning page_flip on crtc 5, connector 14 Test assertion failure function test_crc, file kms_fbc_crc.c:314: Last errno: 0, Success Failed assertion: igt_crc_equal(&crcs[0], &data->ref_crc[1]) Subtest page_flip: FAIL Beginning mmap_cpu on crtc 5, connector 14 mmap_cpu on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest mmap_cpu: SKIP Beginning mmap_gtt on crtc 5, connector 14 mmap_gtt on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest mmap_gtt: SKIP Beginning blt on crtc 5, connector 14 blt on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest blt: SKIP Beginning render on crtc 5, connector 14 render on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest render: SKIP Beginning context on crtc 5, connector 14 context on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest context: SKIP Beginning page_flip_and_mmap_cpu on crtc 5, connector 14 page_flip_and_mmap_cpu on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest page_flip_and_mmap_cpu: SKIP Beginning page_flip_and_mmap_gtt on crtc 5, connector 14 page_flip_and_mmap_gtt on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest page_flip_and_mmap_gtt: SKIP Beginning page_flip_and_blt on crtc 5, connector 14 page_flip_and_blt on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest page_flip_and_blt: SKIP Beginning page_flip_and_render on crtc 5, connector 14 page_flip_and_render on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest page_flip_and_render: SKIP Beginning page_flip_and_context on crtc 5, connector 14 page_flip_and_context on crtc 5, connector 14: PASSED Test requirement not met in function prepare_crtc, file kms_fbc_crc.c:385: Last errno: 0, Success Test requirement: (!fbc_enabled(data)) Subtest page_flip_and_context: SKIP " *Reproduce steps: ---------------------------- 1. ./kms_fbc_crc
commit f85fff0de620bc20d8a20896812fcce584983f28 Author: Ville Syrjälä <ville.syrjala@linux.intel.com> Date: Thu May 8 15:56:24 2014 +0300 tests/kms_fbc_crc: Allow the subtests to pass even if some planes aren't FBC capable Don't skip the entire subtest if FBC only works on some of the primary planes, as is the case on pre-gen4 and hsw+. Only skip the entire subtest if all crtc/connector combinations skip. Also print some kind of status for all otherwise valid crtc/connector combos if they skip due to FBC being disabled or CRC support not being there. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> This should fix it. Seems I forgot to add the bugzilla tag there. Oh well.
(In reply to comment #1) > commit f85fff0de620bc20d8a20896812fcce584983f28 > Author: Ville Syrjälä <ville.syrjala@linux.intel.com> > Date: Thu May 8 15:56:24 2014 +0300 > > tests/kms_fbc_crc: Allow the subtests to pass even if some planes aren't > FBC capable > > Don't skip the entire subtest if FBC only works on some of the primary > planes, as is the case on pre-gen4 and hsw+. Only skip the entire subtest > if all crtc/connector combinations skip. > > Also print some kind of status for all otherwise valid crtc/connector > combos > if they skip due to FBC being disabled or CRC support not being there. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > This should fix it. Seems I forgot to add the bugzilla tag there. Oh well. I didn't find this commit on -next-queued(1cf0ba14740d96fbf6f58a201f000a34b74f4725)branch, could you tell me which branch this commit on? thanks.
(In reply to comment #2) > (In reply to comment #1) > > commit f85fff0de620bc20d8a20896812fcce584983f28 > > Author: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Date: Thu May 8 15:56:24 2014 +0300 > > > > tests/kms_fbc_crc: Allow the subtests to pass even if some planes aren't > > FBC capable > > > > Don't skip the entire subtest if FBC only works on some of the primary > > planes, as is the case on pre-gen4 and hsw+. Only skip the entire subtest > > if all crtc/connector combinations skip. > > > > Also print some kind of status for all otherwise valid crtc/connector > > combos > > if they skip due to FBC being disabled or CRC support not being there. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > This should fix it. Seems I forgot to add the bugzilla tag there. Oh well. > > I didn't find this commit on > -next-queued(1cf0ba14740d96fbf6f58a201f000a34b74f4725)branch, could you tell > me which branch this commit on? thanks. igt master
Verified with igt(d848a36545eec43760de7e34a57a796182358087). ./kms_fbc_crc IGT-Version: 1.6-gd848a36 (x86_64) (Linux: 3.15.0-rc3_drm-intel-fixes_05adaf_20140512+ x86_64) Beginning page_flip on crtc 5, connector 14 Test assertion failure function test_crc, file kms_fbc_crc.c:333: Last errno: 0, Success Failed assertion: igt_crc_equal(&crcs[0], &data->ref_crc[1]) Subtest page_flip: FAIL Beginning mmap_cpu on crtc 5, connector 14 mmap_cpu on crtc 5, connector 14: PASSED Beginning mmap_cpu on crtc 8, connector 14 FBC not enabled mmap_cpu on crtc 8, connector 14: SKIPPED Beginning mmap_cpu on crtc 11, connector 14 FBC not enabled mmap_cpu on crtc 11, connector 14: SKIPPED Subtest mmap_cpu: SUCCESS Beginning mmap_gtt on crtc 5, connector 14 mmap_gtt on crtc 5, connector 14: PASSED Beginning mmap_gtt on crtc 8, connector 14 FBC not enabled mmap_gtt on crtc 8, connector 14: SKIPPED Beginning mmap_gtt on crtc 11, connector 14 FBC not enabled mmap_gtt on crtc 11, connector 14: SKIPPED Subtest mmap_gtt: SUCCESS Beginning blt on crtc 5, connector 14 blt on crtc 5, connector 14: PASSED Beginning blt on crtc 8, connector 14 FBC not enabled blt on crtc 8, connector 14: SKIPPED Beginning blt on crtc 11, connector 14 FBC not enabled blt on crtc 11, connector 14: SKIPPED Subtest blt: SUCCESS Beginning render on crtc 5, connector 14 render on crtc 5, connector 14: PASSED Beginning render on crtc 8, connector 14 FBC not enabled render on crtc 8, connector 14: SKIPPED Beginning render on crtc 11, connector 14 FBC not enabled render on crtc 11, connector 14: SKIPPED Subtest render: SUCCESS Beginning context on crtc 5, connector 14 context on crtc 5, connector 14: PASSED Beginning context on crtc 8, connector 14 FBC not enabled context on crtc 8, connector 14: SKIPPED Beginning context on crtc 11, connector 14 FBC not enabled context on crtc 11, connector 14: SKIPPED Subtest context: SUCCESS Beginning page_flip_and_mmap_cpu on crtc 5, connector 14 page_flip_and_mmap_cpu on crtc 5, connector 14: PASSED Beginning page_flip_and_mmap_cpu on crtc 8, connector 14 FBC not enabled page_flip_and_mmap_cpu on crtc 8, connector 14: SKIPPED Beginning page_flip_and_mmap_cpu on crtc 11, connector 14 FBC not enabled page_flip_and_mmap_cpu on crtc 11, connector 14: SKIPPED Subtest page_flip_and_mmap_cpu: SUCCESS Beginning page_flip_and_mmap_gtt on crtc 5, connector 14 page_flip_and_mmap_gtt on crtc 5, connector 14: PASSED Beginning page_flip_and_mmap_gtt on crtc 8, connector 14 FBC not enabled page_flip_and_mmap_gtt on crtc 8, connector 14: SKIPPED Beginning page_flip_and_mmap_gtt on crtc 11, connector 14 FBC not enabled page_flip_and_mmap_gtt on crtc 11, connector 14: SKIPPED Subtest page_flip_and_mmap_gtt: SUCCESS Beginning page_flip_and_blt on crtc 5, connector 14 page_flip_and_blt on crtc 5, connector 14: PASSED Beginning page_flip_and_blt on crtc 8, connector 14 FBC not enabled page_flip_and_blt on crtc 8, connector 14: SKIPPED Beginning page_flip_and_blt on crtc 11, connector 14 FBC not enabled page_flip_and_blt on crtc 11, connector 14: SKIPPED Subtest page_flip_and_blt: SUCCESS Beginning page_flip_and_render on crtc 5, connector 14 page_flip_and_render on crtc 5, connector 14: PASSED Beginning page_flip_and_render on crtc 8, connector 14 FBC not enabled page_flip_and_render on crtc 8, connector 14: SKIPPED Beginning page_flip_and_render on crtc 11, connector 14 FBC not enabled page_flip_and_render on crtc 11, connector 14: SKIPPED Subtest page_flip_and_render: SUCCESS Beginning page_flip_and_context on crtc 5, connector 14 page_flip_and_context on crtc 5, connector 14: PASSED Beginning page_flip_and_context on crtc 8, connector 14 FBC not enabled page_flip_and_context on crtc 8, connector 14: SKIPPED Beginning page_flip_and_context on crtc 11, connector 14 FBC not enabled page_flip_and_context on crtc 11, connector 14: SKIPPED Subtest page_flip_and_context: SUCCESS
Closing old verified.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.