Please remove exclamation marks from user-visible messages. See this for a rationale: http://techbase.kde.org/Projects/Usability/HIG/Exclamation_points All these appearances of exclamation marks should be eliminated: -------------------- pulseaudio.pot:422(#71) #: ../src/daemon/main.c:726 msgid "Running in system mode, but --disallow-exit not set!" msgstr "" -------------------- pulseaudio.pot:426(#72) #: ../src/daemon/main.c:729 msgid "Running in system mode, but --disallow-module-loading not set!" msgstr "" -------------------- pulseaudio.pot:430(#73) #: ../src/daemon/main.c:732 msgid "Running in system mode, forcibly disabling SHM mode!" msgstr "" -------------------- pulseaudio.pot:434(#74) #: ../src/daemon/main.c:737 msgid "Running in system mode, forcibly disabling exit idle time!" msgstr "" -------------------- pulseaudio.pot:586(#106) #: ../src/daemon/main.c:1006 msgid "Fresh high-resolution timers available! Bon appetit!" msgstr "" -------------------- pulseaudio.pot:590(#107) #: ../src/daemon/main.c:1008 msgid "" "Dude, your kernel stinks! The chef's recommendation today is Linux with high-" "resolution timers enabled!" msgstr "" -------------------- pulseaudio.pot:882(#177) #: ../src/modules/alsa/alsa-sink.c:570 ../src/modules/alsa/alsa-sink.c:748 #, c-format msgid "" "ALSA woke us up to write new data to the device, but there was actually " "nothing to write!\n" "Most likely this is a bug in the ALSA driver '%s'. Please report this issue " "to the ALSA developers.\n" "We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() " "returned 0 or another value < min_avail." msgstr "" -------------------- pulseaudio.pot:893(#178) #: ../src/modules/alsa/alsa-source.c:529 ../src/modules/alsa/alsa-source.c:681 #, c-format msgid "" "ALSA woke us up to read new data from the device, but there was actually " "nothing to read!\n" "Most likely this is a bug in the ALSA driver '%s'. Please report this issue " "to the ALSA developers.\n" "We were woken up with POLLIN set -- however a subsequent snd_pcm_avail() " "returned 0 or another value < min_avail." msgstr "" -------------------- pulseaudio.pot:1708(#347) #: ../src/utils/pacat.c:442 msgid "Warning: Received more uncork requests than cork requests!" msgstr "" -------------------- ===== Found 9 messages satisfying the conditions.
Hello, Please find the resolved patch at below link. http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-June/024084.html Signed-off-by: Deepak Srivastava <srivastava.d at samsung.com> --- src/daemon/main.c | 12 ++++++------ src/modules/alsa/alsa-sink.c | 2 +- src/modules/alsa/alsa-source.c | 2 +- src/utils/pacat.c | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/daemon/main.c b/src/daemon/main.c index 82dec01..8137121 100644 --- a/src/daemon/main.c +++ b/src/daemon/main.c @@ -709,18 +709,18 @@ int main(int argc, char *argv[]) { } if (conf->system_instance && !conf->disallow_exit) - pa_log_warn(_("Running in system mode, but --disallow-exit not set!")); + pa_log_warn(_("Running in system mode, but --disallow-exit not set.")); if (conf->system_instance && !conf->disallow_module_loading) - pa_log_warn(_("Running in system mode, but --disallow-module-loading not set!")); + pa_log_warn(_("Running in system mode, but --disallow-module-loading not set.")); if (conf->system_instance && !conf->disable_shm) { - pa_log_notice(_("Running in system mode, forcibly disabling SHM mode!")); + pa_log_notice(_("Running in system mode, forcibly disabling SHM mode.")); conf->disable_shm = true; } if (conf->system_instance && conf->exit_idle_time >= 0) { - pa_log_notice(_("Running in system mode, forcibly disabling exit idle time!")); + pa_log_notice(_("Running in system mode, forcibly disabling exit idle time.")); conf->exit_idle_time = -1; } @@ -998,9 +998,9 @@ int main(int argc, char *argv[]) { pa_disable_sigpipe(); if (pa_rtclock_hrtimer()) - pa_log_info("Fresh high-resolution timers available! Bon appetit!"); + pa_log_info("Fresh high-resolution timers available! Bon appetit."); else - pa_log_info("Dude, your kernel stinks! The chef's recommendation today is Linux with high-resolution timers enabled!"); + pa_log_info("Dude, your kernel stinks! The chef's recommendation today is Linux with high-resolution timers enabled."); if (conf->lock_memory) { #if defined(HAVE_SYS_MMAN_H) && !defined(__ANDROID__) diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c index fb3c6cc..b6c7d09 100644 --- a/src/modules/alsa/alsa-sink.c +++ b/src/modules/alsa/alsa-sink.c @@ -567,7 +567,7 @@ static int mmap_write(struct userdata *u, pa_usec_t *sleep_usec, bool polled, bo if (polled) PA_ONCE_BEGIN { char *dn = pa_alsa_get_driver_name_by_pcm(u->pcm_handle); - pa_log(_("ALSA woke us up to write new data to the device, but there was actually nothing to write!\n" + pa_log(_("ALSA woke us up to write new data to the device, but there was actually nothing to write.\n" "Most likely this is a bug in the ALSA driver '%s'. Please report this issue to the ALSA developers.\n" "We were woken up with POLLOUT set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail."), pa_strnull(dn)); diff --git a/src/modules/alsa/alsa-source.c b/src/modules/alsa/alsa-source.c index 72c2f6e..d7d3eb5 100644 --- a/src/modules/alsa/alsa-source.c +++ b/src/modules/alsa/alsa-source.c @@ -526,7 +526,7 @@ static int mmap_read(struct userdata *u, pa_usec_t *sleep_usec, bool polled, boo if (polled) PA_ONCE_BEGIN { char *dn = pa_alsa_get_driver_name_by_pcm(u->pcm_handle); - pa_log(_("ALSA woke us up to read new data from the device, but there was actually nothing to read!\n" + pa_log(_("ALSA woke us up to read new data from the device, but there was actually nothing to read.\n" "Most likely this is a bug in the ALSA driver '%s'. Please report this issue to the ALSA developers.\n" "We were woken up with POLLIN set -- however a subsequent snd_pcm_avail() returned 0 or another value < min_avail."), pa_strnull(dn)); diff --git a/src/utils/pacat.c b/src/utils/pacat.c index 1262241..2ded613 100644 --- a/src/utils/pacat.c +++ b/src/utils/pacat.c @@ -438,7 +438,7 @@ static void stream_event_callback(pa_stream *s, const char *name, pa_proplist *p pa_operation_unref(pa_stream_cork(s, 0, NULL, NULL)); } if (cork_requests == 0) - pa_log(_("Warning: Received more uncork requests than cork requests!")); + pa_log(_("Warning: Received more uncork requests than cork requests.")); else cork_requests--; } -- 1.7.9.5
Patch applied.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.