Bug 79235 - [i965 Bisected]Ogles1conform, Ogles3conform and most of Piglit cases segfault
Summary: [i965 Bisected]Ogles1conform, Ogles3conform and most of Piglit cases segfault
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high critical
Assignee: Matt Turner
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-26 02:17 UTC by lu hua
Modified: 2014-05-27 02:06 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments

Description lu hua 2014-05-26 02:17:02 UTC 
System Environment:
--------------------------
Platform: Ironlake
Libdrm:		(master)libdrm-2.4.54-9-g8fc62ca8ac010659023bb63c4759eb683de4f9af
Mesa:		(master)c2c639ecf667b4b7cf17cfe33dfe710432f2c43a
Xserver:	(master)xorg-server-1.15.99.902-97-gdb2e708f31a162c6c66643d3559dd5f3e21ee06b
Xf86_video_intel:(master)2.99.911-206-g605fcd9050efc816ac8163e8d626f466d98261c2
Libva:		(staging)35e70cb9b9c77dfb99fb370e319ed501f0c31b17
Libva_intel_driver:(staging)ca1acd54eb59eadabfb40a4b61df2e8968b5e00d
Kernel:	(drm-intel-nightly)c37f30ddc2921eccbf0be87c7742b56fbde53a81

Bug detailed description:
-----------------------------
All Ogles1conform,Ogles2conform, Ogles3conform cases and most of Piglit cases segfault. It happens on i956 platforms with Mesa master branch, It doesn't happen on 10.2 branch.

Bisect shows: f0f7fb181fc267934a44904da4530f50a698b18d is the first bad commit
commit f0f7fb181fc267934a44904da4530f50a698b18d
Author:     Matt Turner <mattst88@gmail.com>
AuthorDate: Mon May 19 10:20:37 2014 -0700
Commit:     Matt Turner <mattst88@gmail.com>
CommitDate: Sat May 24 23:03:23 2014 -0700

    i965: Print disassembly after compaction.

    Reviewed-by: Eric Anholt <eric@anholt.net>

run Piglit case bin/arb_uniform_buffer_object-dlist -fbo -auto
output:
Segmentation fault (core dumped)

Reproduce steps:
----------------------------
1. xinit
2. bin/arb_uniform_buffer_object-dlist -fbo -auto
Comment 2 lu hua 2014-05-27 02:06:18 UTC 
Fixed by commit c9fd68408b83d274722b32b0e23c48d5d6e40862
commit c9fd68408b83d274722b32b0e23c48d5d6e40862
Author: Matt Turner <mattst88@gmail.com>
Date:   Sun May 25 10:30:13 2014 -0700

    i965/fs: Don't modify ann_count if not debugging.

    If we make ann_count non-zero, annotation_finalize() won't bail.

    Not modifying it seems to make the code more clear than would modifying
    annotation_finalize().
Comment 3 lu hua 2014-05-27 02:06:31 UTC 
Verified.Fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.