Bug 79361 - More clang/tartan fixes
Summary: More clang/tartan fixes
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://cgit.collabora.com/git/user/ca...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-05-28 10:48 UTC by Guillaume Desmottes
Modified: 2014-09-17 12:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Guillaume Desmottes 2014-05-28 10:48:18 UTC 
Here are more fixes detected using clang and tartan: http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=tartan
Comment 1 Simon McVittie 2014-09-17 12:16:15 UTC 
 static void
-test_notify_cb (Test *test,
+test_notify_cb (TpAccount *account,
     GParamSpec *pspec,
-    TpAccount *account)
+    Test *test)

The fact that you had to un-swap this seems like a bug in Tartan (Tartan should understand _swapped signal callbacks), but OK.
Comment 2 Simon McVittie 2014-09-17 12:22:45 UTC 
Fixed in git for 0.99.12, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.