Bug 79385 - Fribidi is not thread-safe
Summary: Fribidi is not thread-safe
Status: RESOLVED FIXED
Alias: None
Product: FriBidi
Classification: Unclassified
Component: bidi (show other bugs)
Version: unspecified
Hardware: Other All
: medium blocker
Assignee: Behdad Esfahbod
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-28 19:25 UTC by nfxjfg
Modified: 2014-07-01 22:39 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description nfxjfg 2014-05-28 19:25:05 UTC
It appears fribidi is not thread-safe by default, and using it from multiple threads can lead to crashes. It's possible to build fribidi in a thread-safe way (--enable-malloc AFAIK), but most distros don't do this.

This should be considered an extremely critical issue, because libraries using frbidi will also not be thread-safe.

I suggest disabling the unsafe behavior by default, and making a new release immediately.
Comment 1 Behdad Esfahbod 2014-05-28 21:38:10 UTC
I agree...  I'll get to it soon hopefully...
Comment 2 nfxjfg 2014-06-22 19:52:13 UTC
Ping? All what's needed is changing the default, right? Or is there some kind of blocker?
Comment 3 Behdad Esfahbod 2014-07-01 22:06:28 UTC
I have to find time to fix a bunch of issues and make a new release...
Comment 4 nfxjfg 2014-07-01 22:16:48 UTC
How many years is that going to take?

Sorry, but it's one line change and an EXTREMELY serious issue.
Comment 5 Behdad Esfahbod 2014-07-01 22:21:38 UTC
Here.  Fixed it in master.  Now does that really make much difference without a release?
Comment 6 nfxjfg 2014-07-01 22:39:02 UTC
Thank you!

>Now does that really make much difference without a release?

Yes, it makes a quite extreme difference. If I'd just care about some software I'm using only locally (or imagine I'd be a vendor of some closed-source binary ware), it wouldn't matter. I could patch it myself or statically link against a fixed version.

However, is this software is supposed to be included by distros and what not, dynamically linking to their broken fribidi libs would just turn the software into a crash-party.

So yes, it very much matters to actually _release_ fixes.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.