Bug 79516 - Corruption in feh (image viewer)
Summary: Corruption in feh (image viewer)
Status: VERIFIED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-01 21:24 UTC by Jan Alexander Steffens (heftig)
Modified: 2014-06-02 18:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Xorg :0 log (83.98 KB, text/plain)
2014-06-02 08:49 UTC, Jan Alexander Steffens (heftig)
no flags Details

Description Jan Alexander Steffens (heftig) 2014-06-01 21:24:55 UTC
Arch Linux x86_64
Thinkpad X220t (SNB)
xf86-video-intel ffbe0aa (TearFree enabled)
xorg-server 1.15.1
linux 3.14.5

When opening a JPEG (not PNG) image using the feh image viewer and making the window narrower but taller than the image, the unused areas show corruption when the window is resized or the image is moved.
Comment 1 Chris Wilson 2014-06-02 06:43:42 UTC
Doesn't happen for me, yet. Can you attach your Xorg.0.log and tell me what version of feh and window manager/compositor your are using?
Comment 2 Jan Alexander Steffens (heftig) 2014-06-02 08:49:55 UTC
Created attachment 100276 [details]
Xorg :0 log

Compositor/WM: gnome-shell 3.12.2
feh 2.12
Comment 3 Jan Alexander Steffens (heftig) 2014-06-02 09:10:07 UTC
Current release 2.99.911 is unaffected. I'll bisect when I have time.

I've also noticed corruption in Eclipse, when selecting text. Aagain, only master, not release.
Comment 4 Chris Wilson 2014-06-02 09:13:47 UTC
Ta. I'll keep on trying to reproduce this in the meantime.
Comment 5 Jan Alexander Steffens (heftig) 2014-06-02 18:26:29 UTC
The first bad commit is 961139f (sna: Use manual detiling for downloads)
Comment 6 Chris Wilson 2014-06-02 18:54:38 UTC
(In reply to comment #5)
> The first bad commit is 961139f (sna: Use manual detiling for downloads)

Caught, should be fixed by 

commit 4cafd1fbb1a2441a9ba5dac7f2a0e1b3f5957c62
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Jun 2 16:01:10 2014 +0100

    sna: Fix early return in download using the GPU
    
    In commit 961139f5878572ebea268a0bbf47caf05af9093f
    Author: Chris Wilson <chris@chris-wilson.co.uk>
    Date:   Fri May 30 09:45:15 2014 +0100
    
        sna: Use manual detiling for downloads
    
    the code for deciding when to use the GPU was refactored into a new
    function that also performed the transfer, but failed to notice the
    early return.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 7 Jan Alexander Steffens (heftig) 2014-06-02 18:58:49 UTC
Indeed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.