Bug 79797 - Move automake version check from autogen.sh to configure.ac
Summary: Move automake version check from autogen.sh to configure.ac
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-08 14:18 UTC by Hib Eris
Modified: 2014-07-10 22:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Move automake version check from autogen.sh to configure.ac (2.73 KB, patch)
2014-06-08 14:18 UTC, Hib Eris 		Details | Splinter Review
View All

Description Hib Eris 2014-06-08 14:18:44 UTC 

    


    


      



        
          Comment 1
        

        
          Hib Eris

        

        
        

        
          2014-06-08 14:18:48 UTC
        

      






Created attachment 100660 [details] [review]
Move automake version check from autogen.sh to configure.ac

    


    


      



        
          Comment 2
        

        
          Albert Astals Cid

        

        
        

        
          2014-06-08 14:28:01 UTC
        

      






Why?

    


    


      



        
          Comment 3
        

        
          Hib Eris

        

        
        

        
          2014-06-08 14:38:56 UTC
        

      






(In reply to comment #2)
> Why?

- Because it means less code that you have to maintain. E.g. the old code has to be updated for automake-1.15 when that comes out.

- Because it makes it easier to understand what autogen.sh does.

I have to agee however, these are only small benefits.

    


    


      



        
          Comment 4
        

        
          Albert Astals Cid

        

        
        

        
          2014-07-10 22:26:05 UTC
        

      






Pushed to master, thanks!

    



  






  














    


  Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.