Created attachment 100661 [details] [review]
[glib] doc: Move PopplerColor documentation to it's own section

Created attachment 100662 [details] [review]
[glib] doc: Move poppler_get_{version, backend} documentation to features section

Created attachment 100663 [details] [review]
[glib] doc: Move PopplerError to PopplerDocument section

Created attachment 100664 [details] [review]
[glib] doc: Move PopplerPrintFlags to PopplerPage section

Created attachment 100665 [details] [review]
[glib] doc: Move PopplerFindFlags to PopplerPage section

And also add the missing POPPLER_TYPE_FIND_FLAGS and poppler_find_flags_get_type.

Created attachment 100666 [details] [review]
[glib] doc: Add poppler_annot_set_flags() to documentation

Created attachment 100667 [details] [review]
[glib] doc: Fix typo

Created attachment 100668 [details] [review]
[glib] doc: Add missing POPPLER_TYPE_POINT

And while we are here, also move poppler_point_get_type() and
poppler_quadrilateral_get_type() to private subsection.

Created attachment 100669 [details] [review]
[glib] doc: Add PopplerBackend documentation

Created attachment 100670 [details] [review]
[glib] doc: Use <emphasis> instead of <em>

Fixes:
  DOC   Building HTML
Element em in namespace '' encountered in para, but no template matches.

Created attachment 100671 [details] [review]
[glib] doc: Document PopplerFindFlags:POPPLER_FIND_DEFAULT

Fixes warning:
  DOC   Building XML
../../glib/poppler.h:157: warning: Value description for
PopplerFindFlags::POPPLER_FIND_DEFAULT is missing in source code comment
block.

Created attachment 100675 [details] [review]
[glib] doc: Move PopplerError to PopplerDocument section

Created attachment 100676 [details] [review]
[glib] doc: Move poppler_date_parse to utility functions section

Created attachment 100677 [details] [review]
For download convenience, all patches in one file

For applying with 'git am'.

You can fetch these patches from my public git repository with:

git fetch git@gitorious.org:hiberis/poppler.git bfo-79798 && git checkout -b bfo-79798 FETCH_HEAD

(In reply to comment #15)
> You can fetch these patches from my public git repository with:
> 
> git fetch git@gitorious.org:hiberis/poppler.git bfo-79798 && git checkout -b
> bfo-79798 FETCH_HEAD

Whoops, that should be:

git fetch git://gitorious.org/hiberis/poppler.git bfo-79798 && git checkout -b bfo-79798 FETCH_HEAD

Comment on attachment 100675 [details] [review]
[glib] doc: Move PopplerError to PopplerDocument section

Review of attachment 100675 [details] [review]:
-----------------------------------------------------------------

I'm not sure about this one, while it's tru that it's only used for document related errors, it's still PopplerError and not PopplerDocumentError, it might be expanded in the future for other errors. I've pushed all other patches to git master. Thanks!

(In reply to comment #17)
> Comment on attachment 100675 [details] [review] [review]
> [glib] doc: Move PopplerError to PopplerDocument section
> 
> Review of attachment 100675 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> I'm not sure about this one, while it's tru that it's only used for document
> related errors, it's still PopplerError and not PopplerDocumentError, it
> might be expanded in the future for other errors. I've pushed all other
> patches to git master. Thanks!

How about moving it to it's own section then? I've provided a patch to do that in 
#79837 .

How about moving it to it's own section then? I've provided a patch to do that in 
bug 79837.

I pushed all the patches in bug #79837, if there's anything pending, please reopen the bug.