The geometry file for thinkpads defines two geometries, "us" and "intl", both based on the partial "common". But the rules file only maps the model "thinkpad" to "ibm_vndr/thinkpad(common)", which leads to the display of a keyboard without the alphabetic keys in gnome-keyboard-properties. I'll attach a patch to add a separate thinkpad model for the intl layout, and map the existing model to "us".
Created attachment 6676 [details] [review] patch
This patch modifies the rules/base file directly, instead of the various .part files. Is that right?
Yes, sorry. I hadn't enough brain left after grokking the XKB config system to grok the xkeyboard-config build system...
Mathias, would you mind if I move thinkpad from ibm_vndr one level up? It is the only file in that directory. I think it is a bit of overkill - have one geometry file per directory.
Sounds totally fine to me.
OK. Done.
BTW, I must admit - thinkpad geometry is probably the most nicely looking geometry in the whole database.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.