Bug 7992 - Support Dell Precision M65
Summary: Support Dell Precision M65
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Matthias Clasen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-24 20:49 UTC by Matthias Clasen
Modified: 2007-09-25 21:37 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch (11.57 KB, patch)
2006-08-24 20:49 UTC, Matthias Clasen
Details | Splinter Review
new patch (12.37 KB, patch)
2007-09-05 15:36 UTC, Matthias Clasen
Details | Splinter Review

Description Matthias Clasen 2006-08-24 20:49:34 UTC
I have written a geometry description for keyboard of this laptop;
I'll attach a patch
Comment 1 Matthias Clasen 2006-08-24 20:49:54 UTC
Created attachment 6678 [details] [review]
patch
Comment 2 Alexander Larsson 2006-08-30 01:41:26 UTC
This patch modifies the rules/base file directly, instead of the various .part
files. Is that right?
Comment 3 Sergey V. Udaltsov 2006-08-30 01:45:55 UTC
No, it is not right. I would prefer patches against .part files. Though in many
cases I can figure out how to split the original patch (and do it manually).
Comment 4 Sergey V. Udaltsov 2006-09-03 15:42:38 UTC
Matthias, could you please fix the patch to deal with .part files?
Comment 5 Matthias Clasen 2006-09-03 17:17:24 UTC
It may take me some time
Comment 6 Sergey V. Udaltsov 2006-09-03 17:18:07 UTC
Take your time;)
Comment 7 Matthias Clasen 2007-09-05 15:36:05 UTC
Created attachment 11440 [details] [review]
new patch

Here is a new patch that seems to work just as well.
Comment 8 Sergey V. Udaltsov 2007-09-05 15:58:10 UTC
That patch is generally ok. I am committing it. But could you please explain why do you explicitly set LWIN as Super_L ?

Comment 9 Sergey V. Udaltsov 2007-09-05 16:02:12 UTC
It is committed anyway - but I'd like to get the answer regarding LWIN
Comment 10 Matthias Clasen 2007-09-25 21:37:10 UTC
I honestly don't recall. If that looks unusual or broken, feel free to correct it.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.