Bug 79929 (xdg-utils) - xdg-email should at least check for assigned mailto instead of going straight to browser
Summary: xdg-email should at least check for assigned mailto instead of going straight...
Status: RESOLVED FIXED
Alias: xdg-utils
Product: Portland
Classification: Unclassified
Component: xdg-utils (show other bugs)
Version: 1.1.0 rc1
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Portland Bugs
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-06-11 21:19 UTC by dodo
Modified: 2015-07-01 16:27 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
email should be checked for non DE environments (911 bytes, text/plain)
2014-06-11 21:19 UTC, dodo
Details

Description dodo 2014-06-11 21:19:23 UTC
Created attachment 100904 [details]
email should be checked for non DE environments

without exporting DE variable there should be a check to see if user has set a mailto. Attached is a proposed change to xdg-email open_generic function. Probably needs to be looked at. Let me know what you guys think.
Comment 1 Rex Dieter 2014-06-12 13:25:19 UTC
I agree with this approach, thanks.
Comment 2 dodo 2014-06-12 18:49:13 UTC
(In reply to comment #1)
> I agree with this approach, thanks.

Okay great. Is there anything else you would like me to do to test or anything else? I tried removing gvfs and libgnome to make sure that the function would still work (it did here).
Comment 3 Rex Dieter 2014-09-19 18:16:46 UTC
committed, thanks!
Comment 4 dodo 2014-09-19 19:28:09 UTC
(In reply to comment #3)
> committed, thanks!

Thank you.
Comment 5 Rodrigo Tobar 2015-07-01 14:46:13 UTC
I was running into this same issue and after much searching I stumbled upon this bug report. It is marked as resolved, and Rex Dieter reported that the patch was committed, but I couldn't find neither the commit in the git repository nor the contents of the patch in the script in the current master branch. Maybe it was committed but got lost during some push? Thanks!
Comment 6 Rex Dieter 2015-07-01 16:09:43 UTC
indeed, looks like I made a snafu here, will fix shortly.  thanks for catching my error
Comment 7 Rex Dieter 2015-07-01 16:27:38 UTC
Committed for real this time:
http://cgit.freedesktop.org/xdg/xdg-utils/commit/?id=c7f40a509c18894ed85e0be9013a5bc31f16537e


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.