Bug 79993 - [TearFree] Damage tracking problems
Summary: [TearFree] Damage tracking problems
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Chris Wilson
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 17:00 UTC by trondsg+bugzilla+freedesktop
Modified: 2015-01-31 10:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
screenshot of problem (528.35 KB, image/png)
2014-06-13 17:00 UTC, trondsg+bugzilla+freedesktop
no flags Details
screenshot of menu problem (156.41 KB, image/png)
2014-06-13 17:03 UTC, trondsg+bugzilla+freedesktop
no flags Details
screen menu problem 2 (379.00 KB, image/png)
2014-06-13 17:05 UTC, trondsg+bugzilla+freedesktop
no flags Details
taskbar problem (292.52 KB, image/png)
2014-06-13 17:10 UTC, trondsg+bugzilla+freedesktop
no flags Details
current xorg log (may not be related) (23.16 KB, text/plain)
2014-06-13 17:18 UTC, trondsg+bugzilla+freedesktop
no flags Details
frame not refreshed (916.62 KB, image/png)
2014-06-15 10:22 UTC, trondsg+bugzilla+freedesktop
no flags Details
xorg.0.log for frame not refreshed (23.03 KB, text/plain)
2014-06-15 10:23 UTC, trondsg+bugzilla+freedesktop
no flags Details
Restoration of one change from fb51ec4 (682 bytes, patch)
2014-08-18 17:30 UTC, Mihail Kasadjikov
no flags Details | Splinter Review

Description trondsg+bugzilla+freedesktop 2014-06-13 17:00:33 UTC
Created attachment 100989 [details]
screenshot of problem

xorg-video-intel package: 2:2.99.910-0ubuntu1

I can't remember how recently this was updated, though, so some of these problem might be fixed in this version. I took the attached screenshots during the past weeks.

I have tearfree on in xorg.conf, vsync off in xfce compositing manager, and shadows on in xfce compositing manager.

The problems with the menu (see screenshots) appeared with tearfree on and shadows on.

The problem with black taskbar I think is irrespective of this shadows and tearfree. Although it seemed to worsen with tearfree on. To the point of having a chronic black thing on the indicator applet.

The taskbar is gtk2, the indicator applet is gtk3. I also had blackness in some other gtk3 programs. The gtk3 problems have been gone after I switched from the fallback theme to adwaita. I don't know whether this points to a bug in gtk or simply that the fallback theme is more sensitive to damage tracking problems.

Unfortunately I don't have the xorg log from these events, but when it happens again I will attach it. The current xorg log doesn't seem to show any problems.

More pictures will be attached.
Comment 1 trondsg+bugzilla+freedesktop 2014-06-13 17:03:54 UTC
Created attachment 100990 [details]
screenshot of menu problem
Comment 2 trondsg+bugzilla+freedesktop 2014-06-13 17:05:47 UTC
Created attachment 100991 [details]
screen menu problem 2
Comment 3 trondsg+bugzilla+freedesktop 2014-06-13 17:10:42 UTC
Created attachment 100993 [details]
taskbar problem
Comment 4 trondsg+bugzilla+freedesktop 2014-06-13 17:18:20 UTC
Created attachment 100994 [details]
current xorg log (may not be related)
Comment 5 Chris Wilson 2014-06-13 17:22:13 UTC
I believe I have fixed those in the last 8 months. Please can you at least test with 2.99.912.
Comment 6 trondsg+bugzilla+freedesktop 2014-06-15 10:22:10 UTC
Created attachment 101090 [details]
frame not refreshed
Comment 7 trondsg+bugzilla+freedesktop 2014-06-15 10:23:05 UTC
Created attachment 101091 [details]
xorg.0.log for frame not refreshed
Comment 8 trondsg+bugzilla+freedesktop 2014-06-15 10:26:49 UTC
I can't test with the latest driver version until it gets in the repo for ubuntu.

A problem appaired again with the feature "draw window frame when hovering the button" for the xfce window buttons taskbar applet. Upon minimizing the window, the window contents were left on the screen under this frame.

I got the xorg log for this event.
Comment 9 trondsg+bugzilla+freedesktop 2014-07-03 17:02:13 UTC
This only happens with tearfree on.
Comment 10 Mihail Kasadjikov 2014-08-18 17:30:46 UTC
Created attachment 104837 [details] [review]
Restoration of one change from fb51ec4

Hello.

This issue seems like my problem with screen refreshing when I scroll page in browser or type text in terminal.

The problem appears after this:
commit fb51ec44f4b6069ab854233d5d0da34eb79f754c
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Jun 23 09:07:13 2014 +0100

    sna: Rename IGNORE_CPU to IGNORE_DAMAGE to better reflect its purpose
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

This line in src/sna/sna_accel.c was changed but not just renamed:
from: (flags & REPLACES || !priv->gpu_damage.....
to: (flags & (REPLACES | IGNORE_DAMAGE) || !priv->gpu_damage.....

When I restored only this line the problem was solved.

My patch in attachment.
Comment 11 Chris Wilson 2014-08-18 19:19:56 UTC
(In reply to comment #10)
> Created attachment 104837 [details] [review] [review]
> Restoration of one change from fb51ec4
> 
> Hello.
> 
> This issue seems like my problem with screen refreshing when I scroll page
> in browser or type text in terminal.
> 
> The problem appears after this:
> commit fb51ec44f4b6069ab854233d5d0da34eb79f754c
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Mon Jun 23 09:07:13 2014 +0100
> 
>     sna: Rename IGNORE_CPU to IGNORE_DAMAGE to better reflect its purpose
>     
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> This line in src/sna/sna_accel.c was changed but not just renamed:
> from: (flags & REPLACES || !priv->gpu_damage.....
> to: (flags & (REPLACES | IGNORE_DAMAGE) || !priv->gpu_damage.....
> 
> When I restored only this line the problem was solved.
> 
> My patch in attachment.

Nope. Please file a new bug report. And that is not the root cause of your problem.
Comment 12 Chris Wilson 2014-12-21 15:20:33 UTC
For TearFree, I did just find one more issue:

commit 01ce7efe73538047abd38bbbb95fc4012ebeb9b4
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sat Dec 20 13:36:50 2014 +0000

    sna: Fix Drawable offsets prior to performing shadow discard
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

in 2.99.917. I think it is finally fixed. Might be a while if you are waiting on Ubuntu updating though.
Comment 13 Chris Wilson 2015-01-31 10:28:01 UTC
Presuming now fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.