Bug 80083 - [BYT Bisected]igt/gem_exec_parse some subcases fail
Summary: [BYT Bisected]igt/gem_exec_parse some subcases fail
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Jesse Barnes
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 07:56 UTC by Guo Jinxian
Modified: 2017-10-06 14:37 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (76.93 KB, text/plain)
2014-06-16 07:56 UTC, Guo Jinxian
no flags Details

Description Guo Jinxian 2014-06-16 07:56:23 UTC
Created attachment 101148 [details]
dmesg

==System Environment==
--------------------------
Regression: Yes. 
Good commit on -next-queued: a7bac7fb6c8b077fc11084bf539989f43a45976a

Non-working platforms: BYT

==kernel==
--------------------------
origin/drm-intel-nightly: b438e8793c6d18b0998d75cdf8115a5898ed21d1(fails)
    drm-intel-nightly: 2014y-06m-13d-22h-09m-12s integration manifest
origin/drm-intel-next-queued: 868d665b43473e230d560d5186535270a3d57a19(fails)
    drm/i915: Fix memory leak in intel_dsi_init() error path
origin/drm-intel-fixes: 223a6f2b975ab35d93270ea1d4fb6e0ac6b27fe6(fails)
    drm/i915/bdw: remove erroneous chv specific workarounds from bdw code

==Bug detailed description==
-----------------------------
igt/gem_exec_parse some subcases fail

Case list:
igt/gem_exec_parse/basic-rejected
igt/gem_exec_parse/batch-without-end
igt/gem_exec_parse/bitmasks
igt/gem_exec_parse/oacontrol-tracking
igt/gem_exec_parse/registers


Output:
root@x-byt06:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./gem_exec_parse                                   IGT-Version: 1.7-g8c1566e (x86_64) (Linux: 3.15.0-rc8_drm-intel-next-queued_868d66_20140616+ x86_64)
Subtest basic-allowed: SUCCESS
Test assertion failure function exec_batch, file gem_exec_parse.c:134:
Last errno: 0, Success
Failed assertion: expected_ret == 0
Subtest basic-rejected: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:134:
Last errno: 0, Success
Failed assertion: expected_ret == 0
Subtest registers: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:134:
Last errno: 0, Success
Failed assertion: expected_ret == 0
Subtest bitmasks: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:134:
Last errno: 0, Success
Failed assertion: expected_ret == 0
Subtest batch-without-end: FAIL
Subtest cmd-crossing-page: SUCCESS
Test assertion failure function exec_batch, file gem_exec_parse.c:134:
Last errno: 0, Success
Failed assertion: expected_ret == 0
Subtest oacontrol-tracking: FAIL

==Reproduce steps==
---------------------------- 
1. ./gem_exec_parse
Comment 1 Chris Wilson 2014-06-16 08:18:13 UTC
Please update and attach the new output:

commit 6c4b93fdbc879f95a9843f0ad7a959265b6783f1
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Jun 16 09:01:52 2014 +0100

    igt/gem_exec_parse: Convert to igt_assert_eq
    
    For better test output on failure.
    
    References: https://bugs.freedesktop.org/show_bug.cgi?id=80083
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 Guo Jinxian 2014-06-17 05:47:33 UTC
(In reply to comment #1)
> Please update and attach the new output:
> 
> commit 6c4b93fdbc879f95a9843f0ad7a959265b6783f1
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Mon Jun 16 09:01:52 2014 +0100
> 
>     igt/gem_exec_parse: Convert to igt_assert_eq
>     
>     For better test output on failure.
>     
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=80083
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

root@x-byt06:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./gem_exec_parse
IGT-Version: 1.7-g6c4b93f (x86_64) (Linux: 3.15.0-rc8_drm-intel-nightly_e9ce9f_20140617+ x86_64)
Subtest basic-allowed: SUCCESS
Test assertion failure function exec_batch, file gem_exec_parse.c:135:
Last errno: 0, Success
Failed assertion: __gem_execbuf(fd, &execbuf) == expected_ret
error: 0 == -22
Subtest basic-rejected: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:135:
Last errno: 0, Success
Failed assertion: __gem_execbuf(fd, &execbuf) == expected_ret
error: 0 == -22
Subtest registers: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:135:
Last errno: 0, Success
Failed assertion: __gem_execbuf(fd, &execbuf) == expected_ret
error: 0 == -22
Subtest bitmasks: FAIL
Test assertion failure function exec_batch, file gem_exec_parse.c:135:
Last errno: 0, Success
Failed assertion: __gem_execbuf(fd, &execbuf) == expected_ret
error: 0 == -22
Subtest batch-without-end: FAIL
Subtest cmd-crossing-page: SUCCESS
Test assertion failure function exec_batch, file gem_exec_parse.c:135:
Last errno: 0, Success
Failed assertion: __gem_execbuf(fd, &execbuf) == expected_ret
error: 0 == -22
Subtest oacontrol-tracking: FAIL
Comment 3 Guo Jinxian 2014-06-17 07:02:03 UTC
commit 62942ed7279d3e06dc15ae3d47665eff3b373327
Author:     Jesse Barnes <jbarnes@virtuousgeek.org>
AuthorDate: Fri Jun 13 09:28:33 2014 -0700
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Fri Jun 13 18:52:28 2014 +0200

    drm/i915/vlv: disable PPGTT on early revs v3

    Early revs didn't have PPGTT support, so disable there.

    v2: add debug msg when disabling on early stepping
    v3: enable on other B3 packages as well (untested) (Ville)

    References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
    References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

:040000 040000 3deed00b89256ea13eb5031bfdae354a17536b0b 88c4a4b1bcb23bd0966312cb37a00a71f8e97973 M      drivers
Comment 4 Guo Jinxian 2014-06-17 07:03:03 UTC
(In reply to comment #3)
> commit 62942ed7279d3e06dc15ae3d47665eff3b373327
> Author:     Jesse Barnes <jbarnes@virtuousgeek.org>
> AuthorDate: Fri Jun 13 09:28:33 2014 -0700
> Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
> CommitDate: Fri Jun 13 18:52:28 2014 +0200
> 
>     drm/i915/vlv: disable PPGTT on early revs v3
> 
>     Early revs didn't have PPGTT support, so disable there.
> 
>     v2: add debug msg when disabling on early stepping
>     v3: enable on other B3 packages as well (untested) (Ville)
> 
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
>     References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
>     Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>     Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>     Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> :040000 040000 3deed00b89256ea13eb5031bfdae354a17536b0b
> 88c4a4b1bcb23bd0966312cb37a00a71f8e97973 M      drivers

62942ed7279d3e06dc15ae3d47665eff3b373327 is the first bad commit
Comment 5 Jesse Barnes 2014-06-25 22:49:00 UTC
Should be fixed with:

"drm/i915: fix sanitize_enable_ppgtt for full PPGTT"

on the ml today.
Comment 6 Jesse Barnes 2014-06-26 15:30:19 UTC
Ville pointed out that this isn't the right fix for two reasons:
  1) we don't want to enable full PPGTT yet
  2) this bug will still affect early steppings w/o PPGTT

So I'll look at modifying the cmd parser check instead to see if we can get the right return value for these tests.
Comment 7 Jesse Barnes 2014-06-26 15:51:05 UTC
commit 67e29a30d5da57fb6764a23ba9f6aa31ea2c15a8
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Jun 26 08:47:08 2014 -0700

    gem_exec_parse: require PPGTT as well

I opted for this rather than returning 0 from the CMD_PARSER_VERSION check, since that's really just a version number not an enable check (HAS_PARSER returning a version # might have been better, but this is fine too I think).
Comment 8 Guo Jinxian 2014-06-27 06:48:46 UTC
Test passed on latest -nightly(1087d4bf01e79523898c6c31615bf0c369e0039a)

Output:
[root@x-byt01 tests]# ./gem_exec_parse
IGT-Version: 1.7-g7ef5372 (x86_64) (Linux: 3.16.0-rc2_drm-intel-nightly_1087d4_20140627+ x86_64)
Subtest basic-allowed: SUCCESS
Subtest basic-rejected: SUCCESS
Subtest registers: SUCCESS
Subtest bitmasks: SUCCESS
Subtest batch-without-end: SUCCESS
Subtest cmd-crossing-page: SUCCESS
Subtest oacontrol-tracking: SUCCESS
Comment 9 Elizabeth 2017-10-06 14:37:45 UTC
Closing old verified.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.