Bug 8014 - xdm should set the WINDOWPATH environment variable
Summary: xdm should set the WINDOWPATH environment variable
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xdm (show other bugs)
Version: 7.1 (2006.05)
Hardware: All All
: high enhancement
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-25 16:52 UTC by Samuel Thibault
Modified: 2007-02-02 13:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
have xdm set the WINDOWPATH environment variable (6.99 KB, patch)
2006-08-25 16:52 UTC, Samuel Thibault
no flags Details | Splinter Review

Description Samuel Thibault 2006-08-25 16:52:14 UTC
Hi,

As discussed some time ago on xorg@freedesktop.org (starting from http://lists.freedesktop.org/archives/xorg/2005-December/011434.html, and agreed on on http://lists.freedesktop.org/archives/xorg/2005-December/011470.html ), braille accessibility of X applications and text applications running in xterms both need a WINDOWPATH environment variable that contains the "window path" of the X server, i.e. the list of VT or Xnest windows that lead to the actual session. It might be useful for other uses too.

The attached patch implements this in xdm.

Samuel
Comment 1 Samuel Thibault 2006-08-25 16:52:46 UTC
Created attachment 6702 [details] [review]
have xdm set the WINDOWPATH environment variable
Comment 2 Alan Coopersmith 2006-08-25 17:15:33 UTC
Why do this in each method of starting X (xdm, xinit, gdm, etc.) instead of just 
once in the X server?
Comment 3 Alan Coopersmith 2006-08-25 17:16:45 UTC
Bah.  Brain fart.   Realized as soon as I clicked "commit" that X server can't set
environment variables for clients.   Should not comment on bugs immediately after
beer bash.
Comment 4 Samuel Thibault 2006-12-12 01:49:37 UTC
Could this be committed some time?

Sorry to put pressure on this, but this was discussed and agreed on almost a year ago, and in the meanwhile we have to tell people to do ugly hacks for having our apps working...
Comment 5 Alan Coopersmith 2007-02-02 13:24:06 UTC
Applied to git head for inclusion in xdm-1.1.4:

commit 5f0f8c00f47e778c59ae22bf685c97756456b2cd
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Thu Feb 1 17:16:41 2007 -0800

    Bug 8014: xdm should set the WINDOWPATH environment variable
    
    X.Org Bug #8014: <https://bugs.freedesktop.org/show_bug.cgi?id=8014>
    Patch #6702: <https://bugs.freedesktop.org/attachment.cgi?id=6702>


Also had to apply a slight fix to make sure windowPath was initialized to 0,
to prevent segfaults from trying to use uninitialized pointer when XFree86_VT
isn't set (either because OS doesn't support VT's or a non-Xorg/XFree86 server
was used) - see git commit 3f1611b69f6b24184aa4b07c796526f49fa0db5f in the xdm
repository.
Comment 6 Samuel Thibault 2007-02-02 13:30:24 UTC
Thanks a lot! 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.