Bug 80176 - [HSW Bisected]igt/drv_module_reload fails
Summary: [HSW Bisected]igt/drv_module_reload fails
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Jesse Barnes
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-18 07:01 UTC by Guo Jinxian
Modified: 2016-09-30 13:08 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg (91.41 KB, text/plain)
2014-06-18 07:01 UTC, Guo Jinxian
no flags Details
dmesg (96.28 KB, text/plain)
2014-06-23 05:43 UTC, Guo Jinxian
no flags Details

Description Guo Jinxian 2014-06-18 07:01:15 UTC
Created attachment 101281 [details]
dmesg

==System Environment==
--------------------------
Regression: Yes. 
Good commit on -fixes: e4c610fe051579ba0a1fadf339905b0231c6ef94

Non-working platforms: HSW

==kernel==
--------------------------
origin/drm-intel-nightly: fff6c5111af7356d3815521f597959554e7bc1cc(fails)
    drm-intel-nightly: 2014y-06m-18d-00h-49m-52s integration manifest
origin/drm-intel-next-queued: 27b6c122512ca30399bb1b39cc42eda83901f304(works)
    drm/i915/chv: Ack interrupts before handling them (CHV)
origin/drm-intel-fixes: 223a6f2b975ab35d93270ea1d4fb6e0ac6b27fe6(fails)
    drm/i915/bdw: remove erroneous chv specific workarounds from bdw code

==Bug detailed description==
-----------------------------
igt/kms_pipe_crc_basic causes "WARNING: CPU: 3 PID: 4309 at drivers/gpu/drm/i915/intel_pm.c:6174 check_power_well_state+0x69/0x6f [i915]()" sporadically


Output:
[root@x-hsw27 tests]# ./drv_module_reload
rmmod: ERROR: Module i915 is in use
WARNING: i915.ko still loaded!
module successfully loaded again

==Reproduce steps==
---------------------------- 
1. ./drv_module_reload
Comment 1 Guo Jinxian 2014-06-19 05:34:36 UTC
4c2e0990ade3251c9b5770aa8f06b06375b66f9f is the first bad commit
commit 4c2e0990ade3251c9b5770aa8f06b06375b66f9f
Author:     Daniel Vetter <daniel.vetter@ffwll.ch>
AuthorDate: Thu Jun 5 16:22:16 2014 +0200
Commit:     Daniel Vetter <daniel.vetter@ffwll.ch>
CommitDate: Fri Jun 6 22:19:54 2014 +0200

    drm/i915: Fixup global gtt cleanup

    The global gtt is setup up in 2 parts, so we need to be careful
    with the cleanup. For consistency shovel it all into the ->cleanup
    callback, like with ppgtt.

    Noticed because it blew up in the out_gtt: cleanup code while
    fiddling with the vgacon code.

    Reviewed-by: Imre Deak <imre.deak@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Output:
[root@x-hsw27 tests]# ./drv_module_reload
module successfully unloaded
Killed
Comment 2 Jesse Barnes 2014-06-20 17:33:22 UTC
The initial report indicates a module refcount issue, but the update looks like it has a crash of some kind.  Does it still occur?  If so, a dmesg after the module unload fails might be helpful.
Comment 3 Guo Jinxian 2014-06-23 05:43:17 UTC
Created attachment 101554 [details]
dmesg

(In reply to comment #2)
> The initial report indicates a module refcount issue, but the update looks
> like it has a crash of some kind.  Does it still occur?  If so, a dmesg
> after the module unload fails might be helpful.

The test still failed on latest -nightly(78f31a2d50183db12c0532eadcf486b9ebfa5f6d)
Output:
[root@x-hsw27 tests]# ./drv_module_reload
rmmod: ERROR: Module i915 is in use
WARNING: i915.ko still loaded!
module successfully loaded again
[root@x-hsw27 tests]# echo $?
1
Comment 4 Jesse Barnes 2014-06-24 20:33:09 UTC
Works here on my HSW, must be an issue with your config or it's fixed now.
Comment 5 Guo Jinxian 2014-07-15 08:21:46 UTC
(In reply to comment #4)
> Works here on my HSW, must be an issue with your config or it's fixed now.

fixed on latest -fixes(ceb9f032dc858c349d7d213454c5ba2c6ef9c5e5)
Comment 6 Jari Tahvanainen 2016-09-30 13:08:22 UTC
Closing Verified+Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.