Bug 803 - DRI merge broke Radeon driver on non-DRI platforms
Summary: DRI merge broke Radeon driver on non-DRI platforms
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) Solaris
: high major
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-26 11:24 UTC by Alan Coopersmith
Modified: 2004-07-15 04:39 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Alan Coopersmith 2004-06-26 11:24:07 UTC
radeon_driver.c can no longer build on non-DRI platforms:
"radeon_driver.c", line 2047: undefined struct/union member: fbLocation
"radeon_driver.c", line 2059: improper member use: fbLocation
"radeon_driver.c", line 2061: improper member use: fbLocation
"radeon_driver.c", line 2062: improper member use: fbLocation

In radeon.h, fbLocation is only defined #ifdef XF86DRI, but there are no 
#ifdefs around the new code in radeon_driver.c to keep it from being used
in those cases.

The simple fix would seem to be adding #ifdefs around those lines, but I don't
know if that would break the driver.
Comment 1 Alan Coopersmith 2004-06-26 11:28:40 UTC
Also, the build of radeon_accel.c fails with similar errors:
"radeon_accel.c", line 287: undefined struct/union member: fbLocation
"radeon_accel.c", line 325: undefined struct/union member: directRenderingEnabled
"radeon_render.c", line 358: undefined struct/union member: fbLocation
"radeon_render.c", line 495: undefined struct/union member: fbLocation
"radeon_render.c", line 632: undefined struct/union member: fbLocation
"radeon_render.c", line 770: undefined struct/union member: fbLocation
"radeon_accelfuncs.c", line 184: undefined struct/union member: fbLocation
"radeon_accelfuncs.c", line 1352: undefined struct/union member:
directRenderingEnabled
Comment 2 Eric Anholt 2004-07-15 21:39:35 UTC
Committed a fix.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.