Bug 8037 - Improve debugging messages in exchange_credentials
Improve debugging messages in exchange_credentials
Status: RESOLVED FIXED
Product: dbus
Classification: Unclassified
Component: core
unspecified
All All
: high enhancement
Assigned To: Havoc Pennington
John (J5) Palmieri
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-27 14:59 UTC by Julio Merino
Modified: 2006-10-13 14:14 UTC (History)
0 users

See Also:


Attachments
Proposed improvement. (2.50 KB, patch)
2006-08-27 14:59 UTC, Julio Merino
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julio Merino 2006-08-27 14:59:11 UTC
The exchange_credentials function calls a couple of functions from dbus-sysdeps
that do some work on the provided socket.  These functions are passed a NULL
value in the DBusError parameter, thus not reporting any error to the parent.

While working on the credentials code, I have found it very useful if these two
error messages were available as debugging messages when DBUS_VERBOSE is
enabled.  I've also added another verbose message at the beginning of the function.

I'm sending these here in case you find them useful too and can be added to the
tree.
Comment 1 Julio Merino 2006-08-27 14:59:28 UTC
Created attachment 6726 [details] [review]
Proposed improvement.
Comment 2 John (J5) Palmieri 2006-10-13 14:14:51 UTC
Committed with some changes.  The file is now dbus-transport-sockets.c and the
second dbus_error_init shouldn't be there. Thanks.