Created attachment 101734 [details] dmesg ==System Environment== -------------------------- Regression: Yes. Good commit on -next-queued: 868d665b43473e230d560d5186535270a3d57a19 Non-working platforms: HSW ==kernel== -------------------------- origin/drm-intel-nightly: 891f8a6bb39ec9a0434c4f8ba468d203e89bf7cd(fails) drm-intel-nightly: 2014y-06m-24d-16h-16m-36s integration manifest origin/drm-intel-next-queued: 9c33baa6b3bbb01c1a88dceba986b20e6642cf31(fails) drivers/i915: Fix unnoticed failure of init_ring_common() origin/drm-intel-fixes: 5b5ffff0d25060ab0e21fa0f6cd16428e87bf1ea(works) drm/i915: Hold the table lock whilst walking the file's idr and counting the objects in debugfs ==Bug detailed description== ----------------------------- igt/pm_rpm/system-suspend cause "WARNING: CPU: 0 PID: 786 at drivers/gpu/drm/i915/i915_irq.c:209 gen6_enable_rps_interrupts+0x39/0x5c [i915]()" Dmesg shows: [ 64.318836] WARNING: CPU: 0 PID: 786 at drivers/gpu/drm/i915/i915_irq.c:209 gen6_enable_rps_interrupts+0x39/0x5c [i915]() [ 64.318844] Modules linked in: dm_mod snd_hda_codec_realtek iTCO_wdt snd_hda_codec_generic iTCO_vendor_support snd_hda_codec_hdmi serio_raw pcspkr i2c_i801 lpc_ich mfd_core snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm snd_timer snd soundcore battery wmi tpm_infineon tpm_tis tpm acpi_cpufreq i915 video button drm_kms_helper drm [ 64.318845] CPU: 0 PID: 786 Comm: kworker/0:1 Not tainted 3.15.0-rc8_kcloud_9c33ba_20140625+ #2 [ 64.318846] Hardware name: ASUS All Series/Z87-EXPERT, BIOS 1008 05/17/2013 [ 64.318851] Workqueue: events intel_gen6_powersave_work [i915] [ 64.318853] 0000000000000000 ffffffff8170a8d4 0000000000000000 ffffffff81033f78 [ 64.318854] ffffffffa0068408 ffff880251380000 ffff880251ac4000 0000000000040000 [ 64.318854] ffff880251388238 ffffffffa0068408 ffff880251380000 ffffffffa006e97c [ 64.318855] Call Trace: [ 64.318859] [<ffffffff8170a8d4>] ? dump_stack+0x41/0x51 [ 64.318861] [<ffffffff81033f78>] ? warn_slowpath_common+0x6f/0x84 [ 64.318867] [<ffffffffa0068408>] ? gen6_enable_rps_interrupts+0x39/0x5c [i915] [ 64.318872] [<ffffffffa0068408>] ? gen6_enable_rps_interrupts+0x39/0x5c [i915] [ 64.318877] [<ffffffffa006e97c>] ? intel_gen6_powersave_work+0xe04/0xefe [i915] [ 64.318880] [<ffffffff81044d0c>] ? process_one_work+0x1c1/0x2ca [ 64.318881] [<ffffffff8104584d>] ? worker_thread+0x1c9/0x2ad [ 64.318882] [<ffffffff81045684>] ? rescuer_thread+0x267/0x267 [ 64.318883] [<ffffffff81049dc2>] ? kthread+0xca/0xd2 [ 64.318884] [<ffffffff81049cf8>] ? kthread_create_on_node+0x15d/0x15d [ 64.318887] [<ffffffff81714dbc>] ? ret_from_fork+0x7c/0xb0 [ 64.318888] [<ffffffff81049cf8>] ? kthread_create_on_node+0x15d/0x15d ==Reproduce steps== ---------------------------- 1. ./pm_rpm --run-subtest system-suspend
If this is a regression, which one is the bad commit?
Reverting the following commit changes the error message: commit e11aa362308f5de467ce355a2a2471321b15a35c Author: Jesse Barnes <jbarnes@virtuousgeek.org> Date: Wed Jun 18 09:52:55 2014 -0700
Created attachment 101893 [details] [review] Possible fix I can reproduce the bug, and, at least on my machine, this patch fixes it. Can you please test it?
Created attachment 102000 [details] dmesg This bug still able to reproduce on latest -nightly(1087d4bf01e79523898c6c31615bf0c369e0039a) [ 86.565858] WARNING: CPU: 0 PID: 1198 at drivers/gpu/drm/i915/i915_irq.c:209 gen6_enable_rps_interrupts+0x39/0x5c [i915]() [ 86.565868] Modules linked in: ip6table_filter ip6_tables ebtable_nat ebtables nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack ipt_REJECT iptable_mangle xt_tcpudp iptable_filter ip_tables x_tables bridge stp llc ipv6 dm_mod snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic iTCO_wdt iTCO_vendor_support dcdbas serio_raw i2c_i801 pcspkr snd_hda_intel snd_hda_controller lpc_ich snd_hda_codec mfd_core snd_hwdep shpchp snd_pcm snd_timer snd soundcore battery acpi_cpufreq i915 video button drm_kms_helper drm [ 86.565870] CPU: 0 PID: 1198 Comm: kworker/0:2 Not tainted 3.16.0-rc2_drm-intel-nightly_1087d4_20140630+ #64 [ 86.565871] Hardware name: Dell Inc. OptiPlex 9020/0DNKMN, BIOS A03 09/17/2013 [ 86.565876] Workqueue: events intel_gen6_powersave_work [i915] [ 86.565878] 0000000000000000 0000000000000009 ffffffff8177f9bf 0000000000000000 [ 86.565878] ffffffff8103983c 0000000000000004 ffffffffa006898d ffff880002e40000 [ 86.565879] ffff880002e40000 ffff880114b8c800 0000000000040000 ffff880002e48298 [ 86.565880] Call Trace: [ 86.565883] [<ffffffff8177f9bf>] ? dump_stack+0x41/0x51 [ 86.565886] [<ffffffff8103983c>] ? warn_slowpath_common+0x78/0x90 [ 86.565890] [<ffffffffa006898d>] ? gen6_enable_rps_interrupts+0x39/0x5c [i915] [ 86.565894] [<ffffffffa006898d>] ? gen6_enable_rps_interrupts+0x39/0x5c [i915] [ 86.565899] [<ffffffffa0070c38>] ? intel_gen6_powersave_work+0xe25/0xf1e [i915] [ 86.565900] [<ffffffff8104d5f6>] ? process_one_work+0x1e2/0x363 [ 86.565902] [<ffffffff8104ddd6>] ? worker_thread+0x2f2/0x3f1 [ 86.565903] [<ffffffff8104dae4>] ? pool_mayday_timeout+0xf2/0xf2 [ 86.565905] [<ffffffff8105254a>] ? kthread+0xc5/0xcd [ 86.565906] [<ffffffff81052485>] ? kthread_freezable_should_stop+0x40/0x40 [ 86.565907] [<ffffffff817854ac>] ? ret_from_fork+0x7c/0xb0 [ 86.565909] [<ffffffff81052485>] ? kthread_freezable_should_stop+0x40/0x40
(In reply to comment #3) > Created attachment 101893 [details] [review] [review] > Possible fix > > I can reproduce the bug, and, at least on my machine, this patch fixes it. > Can you please test it? Jinxian, please try the attached patch on top of nightly.
(In reply to comment #5) > (In reply to comment #3) > > Created attachment 101893 [details] [review] [review] [review] > > Possible fix > > > > I can reproduce the bug, and, at least on my machine, this patch fixes it. > > Can you please test it? > > Jinxian, please try the attached patch on top of nightly. I tried to test 5 times on latest -nightly with this patch. the bug unable to reproduce. thanks.
Fix pushed to -nightly commit 84a2ab8ec76b4fa47f490a01c8186e4b4d757bfe Author: Paulo Zanoni <paulo.r.zanoni@intel.com> Date: Fri Jun 27 18:51:51 2014 -0300 drm/i915: flush delayed_resume_work when suspending
Verified on latest -nightly(026bdf385dec2e1ade18eab75d0eed3997b88e9c).
Closing old verified.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.