Bug 80780 - [i965 Bisected]Piglit spec/EXT_transform_feedback/generatemipmap prims_generated fails
Summary: [i965 Bisected]Piglit spec/EXT_transform_feedback/generatemipmap prims_genera...
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Kenneth Graunke
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-02 03:09 UTC by lu hua
Modified: 2014-07-18 03:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description lu hua 2014-07-02 03:09:46 UTC
System Environment:
--------------------------
Platform: Haswell
Libdrm:		(master)libdrm-2.4.54-17-ge8c3c1358ecaf4e90f7d43762357ae6f8e2022b6
Mesa:		(master)1bfc0a11027449ae7ab7c28eb695f26de530eccf
Xserver:(master)xorg-server-1.15.99.902-121-g2f5cf9ff9a0f713b7e038636484c77f113a5f10a
Xf86_video_intel:(master)2.99.912-200-ge6e5330857097eb2caafa89d571d12e4bb15f539
Libva:		(master)c61d8c6ce9ffc27320e9e177c1e1123d5f1b5014
Libva_intel_driver:(master)c5cb17ea86f0065a939d3636dd26651c93d497c8
Kernel:	(drm-intel-nightly)a7665faa31dbbbae25e376508a9b3781e25d09e2

Bug detailed description:
-----------------------------
It fails on i965 platforms with mesa master branch, works well on 10.2 branch.

Bisect shows: 3178d2474ae5bdd1102fb3d76a60d1d63c961ff5 is the first bad commit.
commit 3178d2474ae5bdd1102fb3d76a60d1d63c961ff5
Author:     Iago Toral Quiroga <itoral@igalia.com>
AuthorDate: Tue Jun 17 13:45:18 2014 +0200
Commit:     Iago Toral Quiroga <itoral@igalia.com>
CommitDate: Mon Jun 30 08:08:50 2014 +0200

    i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

    So far we have been using CL_INVOCATION_COUNT to resolve this query but this
    is no good with streams, as only stream 0 reaches the clipping stage. Instea
    we will use SO_PRIM_STORAGE_NEEDED which can keep track of the primitives se
    to each individual stream.

    Since SO_PRIM_STORAGE_NEEDED is related to the SOL stage and according to
    ARB_transform_feedback3 we need to be able to query primitives generated in
    each stream whether transform feedback is active or not what we do is to
    enable the SOL unit even if transform feedback is not active but disable all
    output buffers in that case. This effectively disables transform feedback
    but permits activation of statistics enabling SO_PRIM_STORAGE_NEEDED even
    when transform feedback is not active.

    Reviewed-by: Chris Forbes <chrisf@ijw.co.nz>


output:
PRIMITIVES_GENERATED counter was incremented during glGenerateMipmapEXT
PIGLIT: {'result': 'fail' }

Reproduce steps:
----------------------------
1. xinit
2. bin/ext_transform_feedback-generatemipmap prims_generated -fbo -auto
Comment 1 lu hua 2014-07-04 02:58:20 UTC
spec/ARB_transform_feedback2/counting with pause fails on BDW with same bisect commit.
Comment 2 lu hua 2014-07-04 03:03:51 UTC
spec/EXT_transform_feedback/primgen-query transform-feedback-disabled also fails on BDW with same bisect commit.

output:
Primitives generated: 0,  Expected: 2
PIGLIT: {'result': 'fail' }
Comment 3 Kenneth Graunke 2014-07-09 07:29:40 UTC
Yeah, this is broken.  Looking into it.
Comment 4 Kenneth Graunke 2014-07-17 17:53:23 UTC
I reverted that commit, so this should be fixed.
Comment 5 lu hua 2014-07-18 03:32:45 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.