Bug 81201 - [BYT Bisected]igt/kms_mmio_vs_cs_flip/setcrtc_vs_cs_flip causes system hang
Summary: [BYT Bisected]igt/kms_mmio_vs_cs_flip/setcrtc_vs_cs_flip causes system hang
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: unspecified
Hardware: Other All
: highest critical
Assignee: Dave Airlie
QA Contact: Intel GFX Bugs mailing list
Depends on:
Reported: 2014-07-11 03:13 UTC by Guo Jinxian
Modified: 2016-10-19 11:07 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

dmesg (62.93 KB, text/plain)
2014-07-24 05:50 UTC, lu hua
no flags Details

Description Guo Jinxian 2014-07-11 03:13:39 UTC
==System Environment==
Regression: Yes. 
The result was fail before(bug 79290)
Good commit on -next-queued: 57127efaf1adc5e0bb2d3fa5a01bd97f71af7836

Non-working platforms: BYT

origin/drm-intel-nightly: 16025dad8e9964a5810385f755d43f1c48d6fdcc(fails)
    drm-intel-nightly: 2014y-07m-09d-14h-17m-14s integration manifest
origin/drm-intel-next-queued: d101c8fe9bda6578ae72d6021415cfaad2b422f0(fails)
    drm/i915: remove i915_rstdby_delays debugfs entry
origin/drm-intel-fixes: 01527b3127997ef6370d5ad4fa25d96847fbf12a(works)
    drm/i915/vlv: T12 eDP panel timing enforcement during reboot

==Bug detailed description==
igt/kms_mmio_vs_cs_flip/setcrtc_vs_cs_flip causes system hang

We can not get dmesg because system hang.

root@x-byt06:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_mmio_vs_cs_flip --run-subtest setcrtc_vs_cs_flip
IGT-Version: 1.7-g6b986a2 (x86_64) (Linux: 3.16.0-rc4_drm-intel-next-queued_7b3c29_20140711+ x86_64)

==Reproduce steps==
1. ./kms_mmio_vs_cs_flip --run-subtest setcrtc_vs_cs_flip
Comment 1 lu hua 2014-07-24 05:50:48 UTC
Created attachment 103376 [details]
Comment 2 Guo Jinxian 2014-08-04 07:52:56 UTC
13cf550448b58abf8f44f5d6a560f2d20871c965 is the first bad commit 
commit 13cf550448b58abf8f44f5d6a560f2d20871c965 
Author: Dave Airlie <airlied@redhat.com> 
AuthorDate: Wed Jun 18 11:29:35 2014 +1000 
Commit: Daniel Vetter <daniel.vetter@ffwll.ch> 
CommitDate: Mon Jul 7 15:08:51 2014 +0200

drm/i915: rework digital port IRQ handling (v2) 

The digital ports from Ironlake and up have the ability to distinguish 
between long and short HPD pulses. Displayport 1.1 only uses the short 
form to request link retraining usually, so we haven't really needed 
support for it until now. 

However with DP 1.2 MST we need to handle the short irqs on their 
own outside the modesetting locking the long hpd's involve. This 
patch adds the framework to distinguish between short/long to the 
current code base, to lay the basis for future DP 1.2 MST work. 

This should mean we get better bisectability in case of regression 
due to the new irq handling. 

v2: add GM45 support (untested, due to lack of hw) 

Signed-off-by: Dave Airlie <airlied@redhat.com> 
Reviewed-by: Todd Previte <tprevite@gmail.com> 
[danvet: Fix conflicts in i915_irq.c with Oscar Mateo's irq handling 
race fixes and a trivial one in intel_drv.h with the psr code.] 
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> 

:040000 040000 7be50985e66c24e64d4de3cccbdcd521ef59903b 8e9cf7373e1c96e78989fd0514e8da8debaad1c4 M drivers 

The commit unable to revert. It's parents commit(564ed191f5d816d24501664296991ec70327e2bc) unable to causes system hang.
Comment 3 Chris Wilson 2014-08-11 05:44:00 UTC
commit f68d697eaf3278200a7fc3c8b1d95d72837b84d8
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Aug 4 07:15:09 2014 +0100

    drm/i915: only hook up hpd pulse for DP outputs
Comment 4 yaoming 2014-08-15 05:36:40 UTC
(In reply to comment #3)
> commit f68d697eaf3278200a7fc3c8b1d95d72837b84d8
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Mon Aug 4 07:15:09 2014 +0100
>     drm/i915: only hook up hpd pulse for DP outputs

It also causes system hang.
Comment 5 Guo Jinxian 2014-08-18 05:52:28 UTC
Verified on latest -nightly(186631131a9289dad22f51315d78b9b6ac5b425f)

root@x-byt06:/GFX/Test/Intel_gpu_tools/intel-gpu-tools/tests# ./kms_mmio_vs_cs_flip --run-subtest setcrtc_vs_cs_flip
IGT-Version: 1.7-g5c7bcb1 (x86_64) (Linux: 3.16.0_drm-intel-nightly_186631_20140818+ x86_64)
Subtest setcrtc_vs_cs_flip: SUCCESS
Comment 6 Jari Tahvanainen 2016-10-19 11:07:40 UTC
Closing verified+fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.