Bug 81279 - RadeonSI in Counter Strike Source [Source Engine] has wrong textures.
Summary: RadeonSI in Counter Strike Source [Source Engine] has wrong textures.
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/Gallium/radeonsi (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-13 03:20 UTC by Aaron B
Modified: 2014-07-19 18:35 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Half-Life 2 Episode One (682.82 KB, image/jpeg)
2014-07-13 16:10 UTC, Tobias Jakobi
Details

Description Aaron B 2014-07-13 03:20:56 UTC
It is definitely not supposed to look how the screen shot does, although I don't really have a before to show either. Before, it looked flowing and great, but now it is obviously very pixelated, probably looking at incorrect pixels from textures for some reason.

I did not test, but guessing by looking at the git commits, commit 04aa2bd724157b8d9e5748b17de10c7517e2c388 may be the one that did it.
Comment 1 Aaron B 2014-07-13 03:27:23 UTC
Picture of problem in CSS. Imgur converts my 1080p png into a .jpg, but you still see the point. Textures are VERY wrong in distance, and up close are very pixelated. Changing AA settings and such has no effect at all.

http://i.imgur.com/m6nEd5n.jpg

It probably is a problem with textures from the GPU, as it is also viewable here. The workspace switcher also shows very pixelated windows, much less clean than before it broke.

http://i.imgur.com/M75a2kr.png
Comment 2 Marek Olšák 2014-07-13 15:20:12 UTC
I don't think 04aa2bd724157b8d9e5748b17de10c7517e2c388. Could you please bisect? Also, what's your LLVM version?
Comment 3 Marek Olšák 2014-07-13 15:20:49 UTC
I just wanted to say that I don't think 04aa2bd724157b8d9e5748b17de10c7517e2c388 is the culprit.
Comment 4 Aaron B 2014-07-13 15:26:07 UTC
(In reply to comment #2)
> I don't think 04aa2bd724157b8d9e5748b17de10c7517e2c388. Could you please
> bisect? Also, what's your LLVM version?

I can't really bisect, Mesa last time I tried to build was broken installing over top my system. But I'm on... it seems to be 3.4. I'm using Oibaf PPA, so basically everything is git-fresh. This happened only about 2 days ago, I just only played a game now and REALLY noticed the problem.
Comment 5 Tobias Jakobi 2014-07-13 16:10:34 UTC
Created attachment 102711 [details]
Half-Life 2 Episode One

Hi,

I think I'm seeing something similar here (also radeonsi on a R9 M265X). I think the shot captures the "blockiness" quite good.

I'm only just setting up this (rather new) system, so I have no idea if it's a regression.

Greets,
Tobias
Comment 6 Aaron B 2014-07-13 18:04:01 UTC
(In reply to comment #5)
> Created attachment 102711 [details]
> Half-Life 2 Episode One
> 
> Hi,
> 
> I think I'm seeing something similar here (also radeonsi on a R9 M265X). I
> think the shot captures the "blockiness" quite good.
> 
> I'm only just setting up this (rather new) system, so I have no idea if it's
> a regression.
> 
> Greets,
> Tobias

Yeah, it is a regression as a few days ago it definitely did not do that. I first thought a change in the way it samples images was changed, thinking the pixelation was just being higher-definition textures or something. But then when playing CSS, I noticed it was definitely wrong, obviously. But there is also a lot of the blocky textures in CSS, too. If that added code didn't cause it, maybe it's the cube texture fix? I'm not too sure at all. I wish I could test it, but Mesa, like I said, installs botched for me too last time I tried to compile last week. Had to reinstall my whole system. Not gonna risk it again. :P
Comment 7 a7456011 2014-07-13 18:07:20 UTC
I also have this problem in DOTA 2 using mesa from the obiaf PPA. Any idea what's going on?
Comment 8 smoki 2014-07-14 06:47:02 UTC
 As i see this is llvm 3.4 only issue (which is version oibaf still build against his mesa packages). Issue does not show up if mesa is build with llvm 3.5 :).
Comment 9 Aaron B 2014-07-14 11:04:21 UTC
(In reply to comment #8)
>  As i see this is llvm 3.4 only issue (which is version oibaf still build
> against his mesa packages). Issue does not show up if mesa is build with
> llvm 3.5 :).

Where do you get your 3.5? I installed the nightly PPA from their site and had no dice with it being fixed.
Comment 10 Marek Olšák 2014-07-14 19:44:33 UTC
I think this is fixed by commit d859bdb4b5beee8059d3e5c0f789dd8ae4061c4. Please test.
Comment 11 smoki 2014-07-14 20:53:26 UTC
(In reply to comment #9)
> (In reply to comment #8)
> >  As i see this is llvm 3.4 only issue (which is version oibaf still build
> > against his mesa packages). Issue does not show up if mesa is build with
> > llvm 3.5 :).
> 
> Where do you get your 3.5? I installed the nightly PPA from their site and
> had no dice with it being fixed.

 I use Debian, both version are available :). Or you can use nightly from llvm site. Of course it is not enough to just install llvm-3.5, you must recompile mesa against it.

(In reply to comment #10)
> I think this is fixed by commit d859bdb4b5beee8059d3e5c0f789dd8ae4061c4.
> Please test.

 Confirmed fixed :).
Comment 12 Aaron B 2014-07-14 22:07:16 UTC
So the commit that requires LLVM 3.5 isn't at fault for me not having it? I'll confirm if it's fixed here next time Oibaf updates Mesa, which probably will be in the next 24 hours or so since it just updated 2 hours ago.
Comment 13 Marek Olšák 2014-07-15 00:08:07 UTC
The Mesa build system doesn't require LLVM 3.5, which means you shouldn't need it. LLVM 3.5 hasn't even been released yet, so Mesa cannot demand it.
Comment 14 Aaron B 2014-07-17 17:15:35 UTC
Fixed, LLVM breakage patched with Mesa commit d859bdb4b5beee8059d3e5c0f789dd8ae4061c4.
Comment 15 Tobias Jakobi 2014-07-19 18:35:11 UTC
Also confirming that this is fixed!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.