Bug 81655 - [SNB+ Bisected]Ogles3conform GL3Tests_shadow_shadow_execution_frag.test fails
Summary: [SNB+ Bisected]Ogles3conform GL3Tests_shadow_shadow_execution_frag.test fails
Status: VERIFIED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: high major
Assignee: Anuj Phogat
QA Contact: Intel 3D Bugs Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-23 02:12 UTC by lu hua
Modified: 2014-12-16 01:06 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
output (119.60 KB, text/plain)
2014-07-23 02:12 UTC, lu hua
Details
output (118.93 KB, text/plain)
2014-08-12 06:11 UTC, lu hua
Details

Description lu hua 2014-07-23 02:12:20 UTC
Created attachment 103310 [details]
output

System Environment:
--------------------------
Platform: SNB 
Libdrm:		(master)libdrm-2.4.54-19-gc0b34dca2632a774249cfa3b969c3f7ce9df33e1
Mesa:		(master)9548ba6e7bb8e631f6ef6236f7425725239742fe
Xserver:	(master)xorg-server-1.15.99.902-121-g2f5cf9ff9a0f713b7e038636484c77f113a5f10a
Xf86_video_intel:(master)2.99.912-248-gbfccacf745d054756661be3edd8898ac6aceb878
Libva:	(master)3fddb7f937df4e0e15391bd65ae3c7552ea5b3d7
Libva_intel_driver:(master)c5cb17ea86f0065a939d3636dd26651c93d497c8

Bug detailed description:
---------------------------
It fails on SNB+ platforms with mesa master branch, works well on 10.2 branch.
GL3Tests_shadow_shadow_execution_vert.test also fail with same bisect commit.

Bisect shows: 9548ba6e7bb8e631f6ef6236f7425725239742fe is the first bad commit.
commit 9548ba6e7bb8e631f6ef6236f7425725239742fe
Author:     Anuj Phogat <anuj.phogat@gmail.com>
AuthorDate: Mon Jul 21 16:58:42 2014 -0700
Commit:     Anuj Phogat <anuj.phogat@gmail.com>
CommitDate: Mon Jul 21 18:33:29 2014 -0700

    mesa: Don't use memcpy() in _mesa_texstore() for float depth texture data

    because float depth texture data needs clamping to [0.0, 1.0]. Let the
    _mesa_texstore() fallback to slower path.

    Fixes Khronos GLES3 CTS tests:
    shadow_execution_vert
    shadow_execution_frag

    V2: Move the check to _mesa_texstore_can_use_memcpy() function.
        Add check for floating point data types.

    Cc: <mesa-stable@lists.freedesktop.org>
    Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak@amd.com>


output:
Skipping ConfigID: 70 Sample Buffers: 1 Samples: 4
Skipping ConfigID: 72 Sample Buffers: 1 Samples: 4
Conformance FAILED 6 of 6 tests.

Reproduce steps:
---------------------------- 
1. xinit
2. ./GTF -width=64 -height=64 -run=GL3Tests/shadow/shadow_execution_frag.test
Comment 1 Ian Romanick 2014-07-29 23:49:05 UTC
In the updated gles3 conformance tests, this test is called ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert.  Are you able to reproduce the failure there?
Comment 2 meng 2014-07-30 02:43:08 UTC
(In reply to comment #1)
> In the updated gles3 conformance tests, this test is called
> ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert.  Are you able to
> reproduce the failure there?

Test the ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert, the issue only can be reproduced on SNB. It works well on IVB and HSW.
Comment 3 meng 2014-07-31 06:53:49 UTC
(In reply to comment #2)
In the updated gles3 conformance tests, with mesa master, the issue can't be reproduced on SNB+.
> the issue only can be reproduced on SNB.
Sorry, it's my mistake. The issue can be reproduced with Mesa 10.2.4 (git-816d37e).
Comment 4 lu hua 2014-07-31 07:39:06 UTC
Run ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert on SNB and HSW platforms.
It works well on Mesa master branch, fails on 10.2 branch.
Comment 5 lu hua 2014-08-01 05:59:30 UTC
Run it on OTC's tree, It fails on mesa master branch, works well on 10.2 branch.
Comment 6 Anuj Phogat 2014-08-07 21:49:58 UTC
Fixed on mesa master by:
commit 9548ba6e7bb8e631f6ef6236f7425725239742fe
Author: Anuj Phogat <anuj.phogat@gmail.com>
Date:   Mon Jul 21 16:58:42 2014 -0700

    mesa: Don't use memcpy() in _mesa_texstore() for float depth texture data
    
    because float depth texture data needs clamping to [0.0, 1.0]. Let the
    _mesa_texstore() fallback to slower path.
    
    Fixes Khronos GLES3 CTS tests:
    shadow_execution_vert
    shadow_execution_frag
    
    V2: Move the check to _mesa_texstore_can_use_memcpy() function.
        Add check for floating point data types.
    
    Cc: <mesa-stable@lists.freedesktop.org>
    Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
    Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Comment 7 lu hua 2014-08-12 06:11:13 UTC
(In reply to comment #6)
> Fixed on mesa master by:
> commit 9548ba6e7bb8e631f6ef6236f7425725239742fe
> Author: Anuj Phogat <anuj.phogat@gmail.com>
> Date:   Mon Jul 21 16:58:42 2014 -0700
> 
>     mesa: Don't use memcpy() in _mesa_texstore() for float depth texture data
>     
>     because float depth texture data needs clamping to [0.0, 1.0]. Let the
>     _mesa_texstore() fallback to slower path.
>     
>     Fixes Khronos GLES3 CTS tests:
>     shadow_execution_vert
>     shadow_execution_frag
>     
>     V2: Move the check to _mesa_texstore_can_use_memcpy() function.
>         Add check for floating point data types.
>     
>     Cc: <mesa-stable@lists.freedesktop.org>
>     Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
>     Reviewed-by: Marek Olšák <marek.olsak@amd.com>


Run on OTC'tree and mesa master commit 9276ef6f41626307, it still fail.
Comment 8 lu hua 2014-08-12 06:11:36 UTC
Created attachment 104467 [details]
output
Comment 9 Matt Turner 2014-10-29 01:10:19 UTC
Someone has missed something.

The original report says a commit that claimed to fix two tests in fact broke them. Then comment six just restates the claim without seeming to acknowledge the report says it broke the tests.
Comment 10 Tapani Pälli 2014-11-07 13:18:41 UTC
This bug (description and comments) is certainly hard to read/understand. I've run the test on IVB laptop against current Mesa master (58a5409) like this:

./glcts --deqp-case=ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert --deqp-gl-config-id=14

and got:

DONE!

Test run totals:
  Passed:        1/1 (100.00%)
  Failed:        0/1 (0.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)

as a result. Does this case fail on some particular platform (like stated in some of the comments)?
Comment 11 lu hua 2014-11-11 07:17:18 UTC
(In reply to Tapani Pälli from comment #10)
> This bug (description and comments) is certainly hard to read/understand.
> I've run the test on IVB laptop against current Mesa master (58a5409) like
> this:
> 
> ./glcts --deqp-case=ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert
> --deqp-gl-config-id=14
> 
> and got:
> 
> DONE!
> 
> Test run totals:
>   Passed:        1/1 (100.00%)
>   Failed:        0/1 (0.00%)
>   Not supported: 0/1 (0.00%)
>   Warnings:      0/1 (0.00%)
> 
> as a result. Does this case fail on some particular platform (like stated in
> some of the comments)?

Test on latest Mesa Master branch.
On OTC's tree, Run ./GTF -width=64 -height=64 -run=GL3Tests/shadow/shadow_execution_frag.tes ,it still fail.
Skipping ConfigID: 82 Sample Buffers: 1 Samples: 4
Skipping ConfigID: 84 Sample Buffers: 1 Samples: 8
Skipping ConfigID: 86 Sample Buffers: 1 Samples: 4
Skipping ConfigID: 88 Sample Buffers: 1 Samples: 8
Conformance FAILED 6 of 6 tests.
Test duration: 3s

On gles3-new tree, run ./glcts --deqp-case=ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert --deqp-gl-config-id=14 ,it works well.
Test run totals:
  Passed:        1/1 (100.00%)
  Failed:        0/1 (0.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)
Comment 12 Kaveh 2014-12-11 18:18:30 UTC
What is the status of this bug? Can we close it?
Comment 13 lu hua 2014-12-16 01:06:03 UTC
Check the result again.  
OTC's tree has one case issue, it still fail, but driver is OK.
Ogles3-new tree is works well.  Close it.
Comment 14 lu hua 2014-12-16 01:06:30 UTC
Verified.Fixed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.